[Libreoffice-commits] core.git: dbaccess/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Aug 23 11:45:17 UTC 2019


 dbaccess/source/ui/dlg/dbwizsetup.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 8d71f19550c969bb322460fd7a06021a0421ba66
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Aug 23 09:55:02 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Aug 23 13:44:21 2019 +0200

    don't call Show on the SfxTabPage
    
    it causes spurious toplevels in the welded case
    
    Change-Id: I321dfaf1d9df1d4a0b80435814e844d8fa29847b
    Reviewed-on: https://gerrit.libreoffice.org/78004
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/dbaccess/source/ui/dlg/dbwizsetup.cxx b/dbaccess/source/ui/dlg/dbwizsetup.cxx
index 78ec885efa14..bc1bd79c581e 100644
--- a/dbaccess/source/ui/dlg/dbwizsetup.cxx
+++ b/dbaccess/source/ui/dlg/dbwizsetup.cxx
@@ -556,7 +556,6 @@ VclPtr<TabPage> ODbTypeWizDialogSetup::createPage(WizardState _nState)
         defaultButton( _nState == PAGE_DBSETUPWIZARD_FINAL ? WizardButtonFlags::FINISH : WizardButtonFlags::NEXT );
         enableButtons( WizardButtonFlags::FINISH, _nState == PAGE_DBSETUPWIZARD_FINAL );
         enableButtons( WizardButtonFlags::NEXT, _nState != PAGE_DBSETUPWIZARD_FINAL );
-        pPage->Show();
 
         m_xAssistant->set_page_title(sIdent, getStateDisplayName(_nState));
     }


More information about the Libreoffice-commits mailing list