[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - cui/uiconfig dbaccess/uiconfig extensions/uiconfig filter/uiconfig sc/uiconfig sd/uiconfig sfx2/uiconfig sw/uiconfig vcl/uiconfig

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Sat Aug 24 08:35:43 UTC 2019


 cui/uiconfig/ui/galleryfilespage.ui               |    2 +-
 dbaccess/uiconfig/ui/backuppage.ui                |    2 +-
 extensions/uiconfig/sabpilot/ui/datasourcepage.ui |    2 +-
 extensions/uiconfig/sabpilot/ui/fieldlinkpage.ui  |    4 ++--
 filter/uiconfig/ui/pdfgeneralpage.ui              |    2 +-
 filter/uiconfig/ui/xmlfiltertabpagegeneral.ui     |    2 +-
 sc/uiconfig/scalc/ui/definedatabaserangedialog.ui |    2 +-
 sc/uiconfig/scalc/ui/textimportcsv.ui             |    2 +-
 sd/uiconfig/simpress/ui/optimpressgeneralpage.ui  |    5 +----
 sd/uiconfig/simpress/ui/publishingdialog.ui       |    2 +-
 sfx2/uiconfig/ui/helpsearchpage.ui                |    2 +-
 sw/uiconfig/swriter/ui/addressblockdialog.ui      |    2 +-
 sw/uiconfig/swriter/ui/charurlpage.ui             |    2 +-
 sw/uiconfig/swriter/ui/frmurlpage.ui              |    2 +-
 sw/uiconfig/swriter/ui/mmmailbody.ui              |    4 ++--
 sw/uiconfig/swriter/ui/mmsalutationpage.ui        |    2 +-
 sw/uiconfig/swriter/ui/optcaptionpage.ui          |    2 +-
 sw/uiconfig/swriter/ui/optfonttabpage.ui          |   10 +++++-----
 sw/uiconfig/swriter/ui/tocentriespage.ui          |    2 +-
 vcl/uiconfig/ui/printdialog.ui                    |    2 +-
 20 files changed, 26 insertions(+), 29 deletions(-)

New commits:
commit 4972b71961c1ab2143d82d9af0ac498063c63ff6
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Aug 23 20:01:33 2019 +0100
Commit:     Adolfo Jayme Barrientos <fitojb at ubuntu.com>
CommitDate: Sat Aug 24 10:34:47 2019 +0200

    Related: tdf#126693 cannot put focus into combobox entry
    
    set can-focus=True in internal GtkComboBoxText GtkEntry where the
    GtkEntry is editable=True
    
    Change-Id: I32cc7686c3a3cb9827f05f192227c0ad39669aa5
    Reviewed-on: https://gerrit.libreoffice.org/78041
    Tested-by: Jenkins
    Reviewed-by: Adolfo Jayme Barrientos <fitojb at ubuntu.com>

diff --git a/cui/uiconfig/ui/galleryfilespage.ui b/cui/uiconfig/ui/galleryfilespage.ui
index 456627d16cd1..99b5888b3d8e 100644
--- a/cui/uiconfig/ui/galleryfilespage.ui
+++ b/cui/uiconfig/ui/galleryfilespage.ui
@@ -53,7 +53,7 @@
                 <property name="width_request">0</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="comboboxtext-entry">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                     <property name="activates_default">True</property>
                   </object>
                 </child>
diff --git a/dbaccess/uiconfig/ui/backuppage.ui b/dbaccess/uiconfig/ui/backuppage.ui
index 6236a0b2b9d9..0ea91eed52f6 100644
--- a/dbaccess/uiconfig/ui/backuppage.ui
+++ b/dbaccess/uiconfig/ui/backuppage.ui
@@ -90,7 +90,7 @@
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="URLBox-entry1">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
diff --git a/extensions/uiconfig/sabpilot/ui/datasourcepage.ui b/extensions/uiconfig/sabpilot/ui/datasourcepage.ui
index 3aa64cca58ca..ac4a90acb281 100644
--- a/extensions/uiconfig/sabpilot/ui/datasourcepage.ui
+++ b/extensions/uiconfig/sabpilot/ui/datasourcepage.ui
@@ -96,7 +96,7 @@ Now, just enter the name under which you want to register the data source in %PR
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="comboboxtext-entry">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
diff --git a/extensions/uiconfig/sabpilot/ui/fieldlinkpage.ui b/extensions/uiconfig/sabpilot/ui/fieldlinkpage.ui
index 060893dacf12..3abf54171d2f 100644
--- a/extensions/uiconfig/sabpilot/ui/fieldlinkpage.ui
+++ b/extensions/uiconfig/sabpilot/ui/fieldlinkpage.ui
@@ -67,7 +67,7 @@
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="combobox-entry2">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
@@ -115,7 +115,7 @@
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="combobox-entry4">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
diff --git a/filter/uiconfig/ui/pdfgeneralpage.ui b/filter/uiconfig/ui/pdfgeneralpage.ui
index 1d5173f2af0f..2f953a1d965c 100644
--- a/filter/uiconfig/ui/pdfgeneralpage.ui
+++ b/filter/uiconfig/ui/pdfgeneralpage.ui
@@ -256,7 +256,7 @@
                                 </items>
                                 <child internal-child="entry">
                                   <object class="GtkEntry" id="comboboxtext-entry">
-                                    <property name="can_focus">False</property>
+                                    <property name="can_focus">True</property>
                                     <property name="activates_default">True</property>
                                     <property name="text" translatable="yes" context="pdfgeneralpage|comboboxtext-entry">75 DPI</property>
                                   </object>
diff --git a/filter/uiconfig/ui/xmlfiltertabpagegeneral.ui b/filter/uiconfig/ui/xmlfiltertabpagegeneral.ui
index b44d0f9fc0d9..24f6f366e85d 100644
--- a/filter/uiconfig/ui/xmlfiltertabpagegeneral.ui
+++ b/filter/uiconfig/ui/xmlfiltertabpagegeneral.ui
@@ -133,7 +133,7 @@
             <property name="has_entry">True</property>
             <child internal-child="entry">
               <object class="GtkEntry" id="comboboxtext-entry">
-                <property name="can_focus">False</property>
+                <property name="can_focus">True</property>
                 <property name="activates_default">True</property>
               </object>
             </child>
diff --git a/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui b/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui
index 4cedef27471d..5f9f02d063e0 100644
--- a/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui
+++ b/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui
@@ -208,7 +208,7 @@
                         <child>
                           <object class="GtkEntry" id="assign">
                             <property name="visible">True</property>
-                            <property name="can_focus">False</property>
+                            <property name="can_focus">True</property>
                             <property name="hexpand">True</property>
                             <property name="activates_default">True</property>
                           </object>
diff --git a/sc/uiconfig/scalc/ui/textimportcsv.ui b/sc/uiconfig/scalc/ui/textimportcsv.ui
index 13cc41491347..0e1c74cecf0d 100644
--- a/sc/uiconfig/scalc/ui/textimportcsv.ui
+++ b/sc/uiconfig/scalc/ui/textimportcsv.ui
@@ -459,7 +459,7 @@
                                         <property name="has_entry">True</property>
                                         <child internal-child="entry">
                                           <object class="GtkEntry" id="comboboxtext-entry">
-                                            <property name="can_focus">False</property>
+                                            <property name="can_focus">True</property>
                                           </object>
                                         </child>
                                       </object>
diff --git a/sd/uiconfig/simpress/ui/optimpressgeneralpage.ui b/sd/uiconfig/simpress/ui/optimpressgeneralpage.ui
index 7c31d4f0c22b..0e902fa0fe64 100644
--- a/sd/uiconfig/simpress/ui/optimpressgeneralpage.ui
+++ b/sd/uiconfig/simpress/ui/optimpressgeneralpage.ui
@@ -540,10 +540,7 @@
                     <property name="popup_fixed_width">False</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="combobox-entry">
-                        <property name="can_focus">False</property>
-                        <property name="xalign">0.5</property>
-                        <property name="shadow_type">none</property>
-                        <property name="caps_lock_warning">False</property>
+                        <property name="can_focus">True</property>
                       </object>
                     </child>
                   </object>
diff --git a/sd/uiconfig/simpress/ui/publishingdialog.ui b/sd/uiconfig/simpress/ui/publishingdialog.ui
index fb1b843f17a8..926f23d6f622 100644
--- a/sd/uiconfig/simpress/ui/publishingdialog.ui
+++ b/sd/uiconfig/simpress/ui/publishingdialog.ui
@@ -878,7 +878,7 @@
                                     <property name="hexpand">True</property>
                                     <child internal-child="entry">
                                       <object class="GtkEntry" id="combobox-entry">
-                                        <property name="can_focus">False</property>
+                                        <property name="can_focus">True</property>
                                       </object>
                                     </child>
                                   </object>
diff --git a/sfx2/uiconfig/ui/helpsearchpage.ui b/sfx2/uiconfig/ui/helpsearchpage.ui
index e610bcb916f2..a8eeec27324e 100644
--- a/sfx2/uiconfig/ui/helpsearchpage.ui
+++ b/sfx2/uiconfig/ui/helpsearchpage.ui
@@ -77,7 +77,7 @@
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="combobox-entry">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
diff --git a/sw/uiconfig/swriter/ui/addressblockdialog.ui b/sw/uiconfig/swriter/ui/addressblockdialog.ui
index 3767fe9c7419..7090396f24ec 100644
--- a/sw/uiconfig/swriter/ui/addressblockdialog.ui
+++ b/sw/uiconfig/swriter/ui/addressblockdialog.ui
@@ -255,7 +255,7 @@
                 <property name="id_column">1</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="comboboxtext-entry">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
diff --git a/sw/uiconfig/swriter/ui/charurlpage.ui b/sw/uiconfig/swriter/ui/charurlpage.ui
index b2436bad3cb2..7496f0aa2c15 100644
--- a/sw/uiconfig/swriter/ui/charurlpage.ui
+++ b/sw/uiconfig/swriter/ui/charurlpage.ui
@@ -156,7 +156,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="comboboxtext-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
diff --git a/sw/uiconfig/swriter/ui/frmurlpage.ui b/sw/uiconfig/swriter/ui/frmurlpage.ui
index 4e7115a13685..4aca7d26e197 100644
--- a/sw/uiconfig/swriter/ui/frmurlpage.ui
+++ b/sw/uiconfig/swriter/ui/frmurlpage.ui
@@ -132,7 +132,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="comboboxtext-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
diff --git a/sw/uiconfig/swriter/ui/mmmailbody.ui b/sw/uiconfig/swriter/ui/mmmailbody.ui
index c6358f9c245a..cc6ee6cdf26f 100644
--- a/sw/uiconfig/swriter/ui/mmmailbody.ui
+++ b/sw/uiconfig/swriter/ui/mmmailbody.ui
@@ -182,7 +182,7 @@
                             <property name="has_entry">True</property>
                             <child internal-child="entry">
                               <object class="GtkEntry" id="comboboxtext-entry1">
-                                <property name="can_focus">False</property>
+                                <property name="can_focus">True</property>
                               </object>
                             </child>
                           </object>
@@ -351,7 +351,7 @@
                                         <property name="has_entry">True</property>
                                         <child internal-child="entry">
                                           <object class="GtkEntry" id="comboboxtext-entry2">
-                                            <property name="can_focus">False</property>
+                                            <property name="can_focus">True</property>
                                           </object>
                                         </child>
                                       </object>
diff --git a/sw/uiconfig/swriter/ui/mmsalutationpage.ui b/sw/uiconfig/swriter/ui/mmsalutationpage.ui
index d2c33bdfd286..684ee2cf1f01 100644
--- a/sw/uiconfig/swriter/ui/mmsalutationpage.ui
+++ b/sw/uiconfig/swriter/ui/mmsalutationpage.ui
@@ -234,7 +234,7 @@
                                 <property name="has_entry">True</property>
                                 <child internal-child="entry">
                                   <object class="GtkEntry" id="comboboxtext-entry">
-                                    <property name="can_focus">False</property>
+                                    <property name="can_focus">True</property>
                                   </object>
                                 </child>
                               </object>
diff --git a/sw/uiconfig/swriter/ui/optcaptionpage.ui b/sw/uiconfig/swriter/ui/optcaptionpage.ui
index a133a127c32e..400429913969 100644
--- a/sw/uiconfig/swriter/ui/optcaptionpage.ui
+++ b/sw/uiconfig/swriter/ui/optcaptionpage.ui
@@ -185,7 +185,7 @@
                             <property name="has_entry">True</property>
                             <child internal-child="entry">
                               <object class="GtkEntry" id="comboboxtext-entry">
-                                <property name="can_focus">False</property>
+                                <property name="can_focus">True</property>
                                 <property name="activates_default">True</property>
                               </object>
                             </child>
diff --git a/sw/uiconfig/swriter/ui/optfonttabpage.ui b/sw/uiconfig/swriter/ui/optfonttabpage.ui
index ddf089499fcc..9a262a4072c8 100644
--- a/sw/uiconfig/swriter/ui/optfonttabpage.ui
+++ b/sw/uiconfig/swriter/ui/optfonttabpage.ui
@@ -213,7 +213,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="standardbox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                       </object>
                     </child>
                   </object>
@@ -232,7 +232,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="titlebox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                       </object>
                     </child>
                   </object>
@@ -251,7 +251,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="listbox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                       </object>
                     </child>
                   </object>
@@ -270,7 +270,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="labelbox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                       </object>
                     </child>
                   </object>
@@ -289,7 +289,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="idxbox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                       </object>
                     </child>
                   </object>
diff --git a/sw/uiconfig/swriter/ui/tocentriespage.ui b/sw/uiconfig/swriter/ui/tocentriespage.ui
index 2891dd174b03..15cdc7422c61 100644
--- a/sw/uiconfig/swriter/ui/tocentriespage.ui
+++ b/sw/uiconfig/swriter/ui/tocentriespage.ui
@@ -305,7 +305,7 @@
                                 <property name="has_entry">True</property>
                                 <child internal-child="entry">
                                   <object class="GtkEntry" id="comboboxtext-entry">
-                                    <property name="can_focus">False</property>
+                                    <property name="can_focus">True</property>
                                     <property name="activates_default">True</property>
                                   </object>
                                 </child>
diff --git a/vcl/uiconfig/ui/printdialog.ui b/vcl/uiconfig/ui/printdialog.ui
index 043a27771a38..bdcf861f83bd 100644
--- a/vcl/uiconfig/ui/printdialog.ui
+++ b/vcl/uiconfig/ui/printdialog.ui
@@ -572,7 +572,7 @@
                                             <child>
                                               <object class="GtkEntry" id="pagerange">
                                                 <property name="visible">True</property>
-                                                <property name="can_focus">False</property>
+                                                <property name="can_focus">True</property>
                                                 <property name="hexpand">True</property>
                                                 <property name="placeholder_text" translatable="yes" context="printdialog|pagerange">e.g.: 1, 3-5, 7, 9</property>
                                               </object>


More information about the Libreoffice-commits mailing list