[Libreoffice-commits] core.git: connectivity/source cui/source

[Noel Grandin (via logerrit)]

 connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx |    2 +-
 cui/source/dialogs/SignSignatureLineDialog.cxx                   |    6 ++----
 cui/source/inc/SignSignatureLineDialog.hxx                       |    2 +-
 3 files changed, 4 insertions(+), 6 deletions(-)

New commits:
commit 32e22584872f1888c49c976f91f41d5edabcb45c
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Sat Aug 24 14:39:28 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Sat Aug 24 16:12:35 2019 +0200

    loplugin:returnconstval in connectivity..cui
    
    Change-Id: Ie6444713088c14d1821640f6eb219cee3d6ee542
    Reviewed-on: https://gerrit.libreoffice.org/78056
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx b/connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx
index f541daad4ce3..b0d83965f2f3 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx
@@ -58,7 +58,7 @@ using ::osl::MutexGuard;
 
 namespace
 {
-const std::type_index getTypeFromMysqlType(enum_field_types type)
+std::type_index getTypeFromMysqlType(enum_field_types type)
 {
     switch (type)
     {
diff --git a/cui/source/dialogs/SignSignatureLineDialog.cxx b/cui/source/dialogs/SignSignatureLineDialog.cxx
index 03549d14fefc..00ad09f4cbef 100644
--- a/cui/source/dialogs/SignSignatureLineDialog.cxx
+++ b/cui/source/dialogs/SignSignatureLineDialog.cxx
@@ -214,8 +214,7 @@ void SignSignatureLineDialog::Apply()
                               xValidGraphic, xInvalidGraphic, m_xEditComment->get_text());
 }
 
-const css::uno::Reference<css::graphic::XGraphic>
-SignSignatureLineDialog::getSignedGraphic(bool bValid)
+css::uno::Reference<css::graphic::XGraphic> SignSignatureLineDialog::getSignedGraphic(bool bValid)
 {
     // Read svg and replace placeholder texts
     OUString aSvgImage(getSignatureImage());
@@ -274,8 +273,7 @@ SignSignatureLineDialog::getSignedGraphic(bool bValid)
     Sequence<PropertyValue> aMediaProperties(1);
     aMediaProperties[0].Name = "InputStream";
     aMediaProperties[0].Value <<= xInputStream;
-    Reference<XGraphic> xGraphic = xProvider->queryGraphic(aMediaProperties);
-    return xGraphic;
+    return xProvider->queryGraphic(aMediaProperties);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
diff --git a/cui/source/inc/SignSignatureLineDialog.hxx b/cui/source/inc/SignSignatureLineDialog.hxx
index a12343c4ecd8..6bd08ff4baef 100644
--- a/cui/source/inc/SignSignatureLineDialog.hxx
+++ b/cui/source/inc/SignSignatureLineDialog.hxx
@@ -42,7 +42,7 @@ private:
     OUString m_sOriginalImageBtnLabel;
 
     void ValidateFields();
-    const css::uno::Reference<css::graphic::XGraphic> getSignedGraphic(bool bValid);
+    css::uno::Reference<css::graphic::XGraphic> getSignedGraphic(bool bValid);
     virtual void Apply() override;
 
     DECL_LINK(clearImage, weld::Button&, void);