[Libreoffice-commits] core.git: compilerplugins/clang dbaccess/source scripting/source vcl/qa

[Noel Grandin (via logerrit)]

 compilerplugins/clang/returnconstval.cxx               |    2 +-
 dbaccess/source/core/recovery/subcomponentrecovery.cxx |    2 +-
 dbaccess/source/core/recovery/subcomponentrecovery.hxx |    2 +-
 scripting/source/stringresource/stringresource.cxx     |    2 +-
 scripting/source/stringresource/stringresource.hxx     |    2 +-
 vcl/qa/cppunit/BitmapTest.cxx                          |    2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 2fd083579d42d7649c162f18db235498198ff3f4
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Aug 22 15:34:12 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Aug 26 08:18:10 2019 +0200

    loplugin:returnconstval in various
    
    Change-Id: Ib5d293417b1faeb7ef63a8df99fc1ba644989cdc
    Reviewed-on: https://gerrit.libreoffice.org/78079
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/returnconstval.cxx b/compilerplugins/clang/returnconstval.cxx
index beab3c654972..3683149c0ee8 100644
--- a/compilerplugins/clang/returnconstval.cxx
+++ b/compilerplugins/clang/returnconstval.cxx
@@ -70,7 +70,7 @@ bool ReturnConstVal::VisitFunctionDecl(const FunctionDecl* functionDecl)
     return true;
 }
 
-loplugin::Plugin::Registration<ReturnConstVal> X("returnconstval", false);
+loplugin::Plugin::Registration<ReturnConstVal> X("returnconstval");
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/dbaccess/source/core/recovery/subcomponentrecovery.cxx b/dbaccess/source/core/recovery/subcomponentrecovery.cxx
index 516aa863f6f2..41020966602b 100644
--- a/dbaccess/source/core/recovery/subcomponentrecovery.cxx
+++ b/dbaccess/source/core/recovery/subcomponentrecovery.cxx
@@ -338,7 +338,7 @@ namespace dbaccess
     void SAL_CALL SettingsDocumentHandler::setDocumentLocator( const Reference< XLocator >& ) {}
 
     // SubComponentRecovery
-    const OUString SubComponentRecovery::getComponentsStorageName( const SubComponentType i_eType )
+    OUString SubComponentRecovery::getComponentsStorageName( const SubComponentType i_eType )
     {
         switch ( i_eType )
         {
diff --git a/dbaccess/source/core/recovery/subcomponentrecovery.hxx b/dbaccess/source/core/recovery/subcomponentrecovery.hxx
index 031df55f7f12..9881778002fe 100644
--- a/dbaccess/source/core/recovery/subcomponentrecovery.hxx
+++ b/dbaccess/source/core/recovery/subcomponentrecovery.hxx
@@ -72,7 +72,7 @@ namespace dbaccess
                     const bool i_bForEditing
                 );
 
-        static const OUString getComponentsStorageName( const SubComponentType i_eType );
+        static OUString getComponentsStorageName( const SubComponentType i_eType );
 
     private:
         void    impl_saveSubDocument_throw(
diff --git a/scripting/source/stringresource/stringresource.cxx b/scripting/source/stringresource/stringresource.cxx
index 2da2fe5be1e1..0387890474fa 100644
--- a/scripting/source/stringresource/stringresource.cxx
+++ b/scripting/source/stringresource/stringresource.cxx
@@ -2647,7 +2647,7 @@ bool StringResourceWithLocationImpl::implLoadLocale( LocaleItem* pLocaleItem )
     return bSuccess;
 }
 
-const Reference< ucb::XSimpleFileAccess3 > StringResourceWithLocationImpl::getFileAccess()
+const Reference< ucb::XSimpleFileAccess3 > & StringResourceWithLocationImpl::getFileAccess()
 {
     ::osl::MutexGuard aGuard( getMutex() );
 
diff --git a/scripting/source/stringresource/stringresource.hxx b/scripting/source/stringresource/stringresource.hxx
index 13ad55a327ec..5e65f06f09b3 100644
--- a/scripting/source/stringresource/stringresource.hxx
+++ b/scripting/source/stringresource/stringresource.hxx
@@ -421,7 +421,7 @@ class StringResourceWithLocationImpl : public StringResourceWithLocationImpl_BAS
     css::uno::Reference< css::ucb::XSimpleFileAccess3 >   m_xSFI;
     css::uno::Reference< css::task::XInteractionHandler > m_xInteractionHandler;
 
-    const css::uno::Reference< css::ucb::XSimpleFileAccess3 > getFileAccess();
+    const css::uno::Reference< css::ucb::XSimpleFileAccess3 > & getFileAccess();
 
     virtual void implScanLocales() override;
     virtual bool implLoadLocale( LocaleItem* pLocaleItem ) override;
diff --git a/vcl/qa/cppunit/BitmapTest.cxx b/vcl/qa/cppunit/BitmapTest.cxx
index b59b7789aa57..fcc630f69bba 100644
--- a/vcl/qa/cppunit/BitmapTest.cxx
+++ b/vcl/qa/cppunit/BitmapTest.cxx
@@ -198,7 +198,7 @@ void BitmapTest::testEmpty()
     CPPUNIT_ASSERT(aBitmap.IsEmpty());
 }
 
-const Bitmap createTestBitmap()
+Bitmap createTestBitmap()
 {
     Bitmap aBmp(Size(4, 4), 24);
     BitmapWriteAccess aBmpAccess(aBmp);