[Libreoffice-commits] core.git: sd/qa

Gabor Kelemen (via logerrit) logerrit at kemper.freedesktop.org
Tue Aug 27 07:32:13 UTC 2019


 sd/qa/unit/SVGExportTests.cxx                |    4 +-
 sd/qa/unit/dialogs-test.cxx                  |   20 ------------
 sd/qa/unit/export-tests-ooxml1.cxx           |   27 ----------------
 sd/qa/unit/export-tests-ooxml2.cxx           |   43 ---------------------------
 sd/qa/unit/export-tests.cxx                  |   36 ----------------------
 sd/qa/unit/filters-test.cxx                  |   12 -------
 sd/qa/unit/import-tests.cxx                  |   11 ------
 sd/qa/unit/misc-tests.cxx                    |    7 ----
 sd/qa/unit/tiledrendering/tiledrendering.cxx |    4 --
 sd/qa/unit/uimpress.cxx                      |    3 -
 10 files changed, 3 insertions(+), 164 deletions(-)

New commits:
commit a1f2f8bdff465ada957f394530cd791a0c329da4
Author:     Gabor Kelemen <kelemen.gabor2 at nisz.hu>
AuthorDate: Sat Aug 24 01:17:53 2019 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Tue Aug 27 09:30:45 2019 +0200

    tdf#42949 Fix IWYU warnings in sd/qa/*cxx
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here.
    
    Change-Id: I7b8c94df79bc7a41d06300d5f637a4eb5c5264f3
    Reviewed-on: https://gerrit.libreoffice.org/78049
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

diff --git a/sd/qa/unit/SVGExportTests.cxx b/sd/qa/unit/SVGExportTests.cxx
index 400d604e786c..63883f49c828 100644
--- a/sd/qa/unit/SVGExportTests.cxx
+++ b/sd/qa/unit/SVGExportTests.cxx
@@ -7,14 +7,14 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#include "sdmodeltestbase.hxx"
+#include <test/bootstrapfixture.hxx>
 
 #include <test/xmltesttools.hxx>
+#include <unotest/macros_test.hxx>
 #include <unotools/mediadescriptor.hxx>
 #include <com/sun/star/frame/XStorable.hpp>
 #include <com/sun/star/frame/Desktop.hpp>
 #include <comphelper/processfactory.hxx>
-#include <com/sun/star/packages/zip/ZipFileAccess.hpp>
 
 #include <boost/preprocessor/stringize.hpp>
 
diff --git a/sd/qa/unit/dialogs-test.cxx b/sd/qa/unit/dialogs-test.cxx
index 21cf07a005cb..102d6f8af58e 100644
--- a/sd/qa/unit/dialogs-test.cxx
+++ b/sd/qa/unit/dialogs-test.cxx
@@ -10,51 +10,31 @@
 #include <memory>
 #include <sal/config.h>
 #include <test/screenshot_test.hxx>
-#include <rtl/strbuf.hxx>
-#include <osl/file.hxx>
 #include <com/sun/star/lang/XComponent.hpp>
-#include <com/sun/star/drawing/XDrawPagesSupplier.hpp>
 #include <com/sun/star/presentation/AnimationEffect.hpp>
 #include <com/sun/star/presentation/ClickAction.hpp>
 
-#include <sfx2/app.hxx>
-#include <sfx2/docfilt.hxx>
-#include <sfx2/docfile.hxx>
 #include <sfx2/sfxdlg.hxx>
-#include <sfx2/sfxmodelfactory.hxx>
 #include <svl/intitem.hxx>
 #include <svl/stritem.hxx>
 #include <svl/aeitem.hxx>
 #include <editeng/colritem.hxx>
-#include <svx/svdtext.hxx>
-#include <svx/svdotext.hxx>
 #include <svx/xfillit0.hxx>
-#include <vcl/sound.hxx>
 #include <vcl/svapp.hxx>
 
 #include <drawdoc.hxx>
 #include <DrawDocShell.hxx>
 
-#include <osl/process.h>
-#include <osl/thread.h>
-
 #include <sdabstdlg.hxx>
 #include <sdpage.hxx>
-#include <vcl/pngwrite.hxx>
 #include <unomodel.hxx>
 #include <ViewShell.hxx>
-#include <Window.hxx>
 #include <drawview.hxx>
-#include <DrawViewShell.hxx>
-#include <app.hrc>
-#include <stlsheet.hxx>
 #include <sdattr.hrc>
 #include <strings.hrc>
 #include <sdresid.hxx>
 #include <sdattr.hxx>
 
-#include <unotest/macros_test.hxx>
-
 using namespace ::com::sun::star;
 
 /// Test opening a dialog in sd
diff --git a/sd/qa/unit/export-tests-ooxml1.cxx b/sd/qa/unit/export-tests-ooxml1.cxx
index de21002e9796..dde6fa42781f 100644
--- a/sd/qa/unit/export-tests-ooxml1.cxx
+++ b/sd/qa/unit/export-tests-ooxml1.cxx
@@ -9,73 +9,46 @@
 #include <officecfg/Office/Common.hxx>
 #include "sdmodeltestbase.hxx"
 #include <Outliner.hxx>
-#include <svl/stritem.hxx>
 #include <editeng/eeitem.hxx>
 #include <editeng/editobj.hxx>
 #include <editeng/outlobj.hxx>
-#include <editeng/ulspitem.hxx>
 #include <editeng/fhgtitem.hxx>
 #include <editeng/escapementitem.hxx>
 #include <editeng/colritem.hxx>
 #include <editeng/fontitem.hxx>
 #include <editeng/wghtitem.hxx>
 #include <editeng/numitem.hxx>
-#include <editeng/lrspitem.hxx>
 #include <editeng/postitem.hxx>
-#include <editeng/bulletitem.hxx>
 
 #include <oox/drawingml/drawingmltypes.hxx>
 
-#include <svl/style.hxx>
-
 #include <svx/svdoutl.hxx>
 #include <svx/svdotext.hxx>
 #include <svx/svdoashp.hxx>
-#include <svx/svdograf.hxx>
 #include <svx/svdogrp.hxx>
-#include <svx/svdomedia.hxx>
-#include <svx/svdoole2.hxx>
-#include <svx/xfillit0.hxx>
 #include <svx/xflclit.hxx>
 #include <svx/xlineit0.hxx>
 #include <svx/sdooitm.hxx>
 #include <svx/sdmetitm.hxx>
-#include <animations/animationnodehelper.hxx>
 #include <unotools/mediadescriptor.hxx>
 #include <rtl/ustring.hxx>
 
-#include <vcl/opengl/OpenGLWrapper.hxx>
-
 #include <com/sun/star/drawing/XDrawPage.hpp>
 #include <com/sun/star/drawing/XDrawPagesSupplier.hpp>
 #include <com/sun/star/beans/XPropertySet.hpp>
-#include <com/sun/star/chart/XChartDocument.hpp>
-#include <com/sun/star/chart2/XChartDocument.hpp>
-#include <com/sun/star/chart2/XDataSeriesContainer.hpp>
-#include <com/sun/star/chart2/XCoordinateSystemContainer.hpp>
-#include <com/sun/star/chart2/XChartTypeContainer.hpp>
-#include <com/sun/star/chart2/data/XLabeledDataSequence.hpp>
-#include <com/sun/star/chart2/data/XDataSequence.hpp>
-#include <com/sun/star/chart2/data/XNumericalDataSequence.hpp>
 #include <com/sun/star/awt/Gradient.hpp>
-#include <com/sun/star/awt/XBitmap.hpp>
 #include <com/sun/star/awt/FontDescriptor.hpp>
-#include <com/sun/star/graphic/XGraphic.hpp>
 #include <com/sun/star/frame/XStorable.hpp>
-#include <com/sun/star/drawing/EnhancedCustomShapeParameterPair.hpp>
 #include <com/sun/star/drawing/FillStyle.hpp>
 #include <com/sun/star/text/WritingMode2.hpp>
-#include <com/sun/star/style/XStyleFamiliesSupplier.hpp>
 #include <com/sun/star/table/BorderLine2.hpp>
 #include <com/sun/star/table/XTable.hpp>
 #include <com/sun/star/table/XMergeableCell.hpp>
 
 #include <svx/svdotable.hxx>
-#include <config_features.h>
 #include <com/sun/star/document/XDocumentPropertiesSupplier.hpp>
 
 using namespace css;
-using namespace css::animations;
 
 class SdOOXMLExportTest1 : public SdModelTestBaseXML
 {
diff --git a/sd/qa/unit/export-tests-ooxml2.cxx b/sd/qa/unit/export-tests-ooxml2.cxx
index 5d1e877eb82a..e2f82aa9d0c0 100644
--- a/sd/qa/unit/export-tests-ooxml2.cxx
+++ b/sd/qa/unit/export-tests-ooxml2.cxx
@@ -8,77 +8,34 @@
  */
 #include <officecfg/Office/Common.hxx>
 #include "sdmodeltestbase.hxx"
-#include <Outliner.hxx>
 #include <comphelper/propertysequence.hxx>
 #include <comphelper/sequence.hxx>
-#include <svl/stritem.hxx>
 #include <editeng/eeitem.hxx>
 #include <editeng/editobj.hxx>
 #include <editeng/outlobj.hxx>
-#include <editeng/ulspitem.hxx>
-#include <editeng/fhgtitem.hxx>
-#include <editeng/escapementitem.hxx>
-#include <editeng/colritem.hxx>
-#include <editeng/fontitem.hxx>
-#include <editeng/wghtitem.hxx>
 #include <editeng/numitem.hxx>
-#include <editeng/lrspitem.hxx>
-#include <editeng/postitem.hxx>
-#include <editeng/bulletitem.hxx>
 #include <editeng/unoprnms.hxx>
 
-#include <oox/drawingml/drawingmltypes.hxx>
-
-#include <svl/style.hxx>
-
-#include <svx/svdoutl.hxx>
 #include <svx/svdotext.hxx>
-#include <svx/svdoashp.hxx>
-#include <svx/svdograf.hxx>
-#include <svx/svdogrp.hxx>
 #include <svx/svdomedia.hxx>
-#include <svx/svdoole2.hxx>
-#include <svx/xflclit.hxx>
 #include <svx/xlineit0.hxx>
 #include <svx/xlndsit.hxx>
-#include <animations/animationnodehelper.hxx>
-#include <unotools/mediadescriptor.hxx>
 #include <rtl/ustring.hxx>
 
-#include <vcl/opengl/OpenGLWrapper.hxx>
-
 #include <com/sun/star/drawing/XDrawPage.hpp>
 #include <com/sun/star/drawing/XDrawPagesSupplier.hpp>
 #include <com/sun/star/animations/TransitionType.hpp>
 #include <com/sun/star/animations/TransitionSubType.hpp>
 #include <com/sun/star/beans/XPropertySet.hpp>
-#include <com/sun/star/chart/XChartDocument.hpp>
-#include <com/sun/star/chart2/XChartDocument.hpp>
-#include <com/sun/star/chart2/XDataSeriesContainer.hpp>
-#include <com/sun/star/chart2/XCoordinateSystemContainer.hpp>
-#include <com/sun/star/chart2/XChartTypeContainer.hpp>
-#include <com/sun/star/chart2/data/XLabeledDataSequence.hpp>
-#include <com/sun/star/chart2/data/XDataSequence.hpp>
-#include <com/sun/star/chart2/data/XNumericalDataSequence.hpp>
 #include <com/sun/star/awt/Gradient.hpp>
-#include <com/sun/star/awt/XBitmap.hpp>
-#include <com/sun/star/awt/FontDescriptor.hpp>
 #include <com/sun/star/awt/Rectangle.hpp>
-#include <com/sun/star/graphic/XGraphic.hpp>
 #include <com/sun/star/drawing/EnhancedCustomShapeParameterPair.hpp>
 #include <com/sun/star/drawing/EnhancedCustomShapeAdjustmentValue.hpp>
 #include <com/sun/star/drawing/FillStyle.hpp>
-#include <com/sun/star/text/WritingMode2.hpp>
-#include <com/sun/star/style/XStyleFamiliesSupplier.hpp>
 #include <com/sun/star/style/LineSpacing.hpp>
 #include <com/sun/star/style/LineSpacingMode.hpp>
-#include <com/sun/star/table/BorderLine2.hpp>
-#include <com/sun/star/table/XTable.hpp>
-#include <com/sun/star/table/XMergeableCell.hpp>
 #include <com/sun/star/frame/XLoadable.hpp>
 
-#include <svx/svdotable.hxx>
-#include <config_features.h>
 #include <com/sun/star/document/XDocumentPropertiesSupplier.hpp>
 
 #include <sdpage.hxx>
diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx
index b3ad838a21ca..b8a17934d441 100644
--- a/sd/qa/unit/export-tests.cxx
+++ b/sd/qa/unit/export-tests.cxx
@@ -10,34 +10,13 @@
 #include "sdmodeltestbase.hxx"
 #include <sdpage.hxx>
 
-#include <Outliner.hxx>
-#include <svl/stritem.hxx>
 #include <editeng/editobj.hxx>
 #include <editeng/outlobj.hxx>
-#include <editeng/ulspitem.hxx>
-#include <editeng/fhgtitem.hxx>
-#include <editeng/escapementitem.hxx>
 #include <editeng/colritem.hxx>
-#include <editeng/fontitem.hxx>
-#include <editeng/wghtitem.hxx>
-#include <editeng/numitem.hxx>
-#include <editeng/lrspitem.hxx>
-#include <editeng/postitem.hxx>
-#include <editeng/bulletitem.hxx>
 
-#include <oox/drawingml/drawingmltypes.hxx>
-
-#include <svl/style.hxx>
-
-#include <svx/svdoutl.hxx>
 #include <svx/svdotext.hxx>
-#include <svx/svdoashp.hxx>
 #include <svx/svdograf.hxx>
-#include <svx/svdogrp.hxx>
 #include <svx/svdomedia.hxx>
-#include <svx/svdoole2.hxx>
-#include <svx/xflclit.hxx>
-#include <animations/animationnodehelper.hxx>
 #include <unotools/mediadescriptor.hxx>
 #include <rtl/ustring.hxx>
 
@@ -46,31 +25,16 @@
 #include <com/sun/star/drawing/XDrawPage.hpp>
 #include <com/sun/star/drawing/XDrawPagesSupplier.hpp>
 #include <com/sun/star/beans/XPropertySet.hpp>
-#include <com/sun/star/chart/XChartDocument.hpp>
-#include <com/sun/star/chart2/XChartDocument.hpp>
-#include <com/sun/star/chart2/XDataSeriesContainer.hpp>
-#include <com/sun/star/chart2/XCoordinateSystemContainer.hpp>
-#include <com/sun/star/chart2/XChartTypeContainer.hpp>
-#include <com/sun/star/chart2/data/XLabeledDataSequence.hpp>
-#include <com/sun/star/chart2/data/XDataSequence.hpp>
-#include <com/sun/star/chart2/data/XNumericalDataSequence.hpp>
 #include <com/sun/star/awt/XBitmap.hpp>
-#include <com/sun/star/awt/FontDescriptor.hpp>
 #include <com/sun/star/graphic/XGraphic.hpp>
 #include <com/sun/star/graphic/GraphicType.hpp>
 #include <com/sun/star/frame/XStorable.hpp>
-#include <com/sun/star/drawing/EnhancedCustomShapeParameterPair.hpp>
-#include <com/sun/star/drawing/FillStyle.hpp>
-#include <com/sun/star/text/WritingMode2.hpp>
 #include <com/sun/star/style/XStyleFamiliesSupplier.hpp>
 #include <com/sun/star/table/BorderLine2.hpp>
-#include <com/sun/star/table/XTable.hpp>
-#include <com/sun/star/table/XMergeableCell.hpp>
 
 
 #include <svx/svdotable.hxx>
 #include <config_features.h>
-#include <com/sun/star/document/XDocumentPropertiesSupplier.hpp>
 
 using namespace css;
 using namespace css::animations;
diff --git a/sd/qa/unit/filters-test.cxx b/sd/qa/unit/filters-test.cxx
index e9ddadfd8806..52fc6f9d7050 100644
--- a/sd/qa/unit/filters-test.cxx
+++ b/sd/qa/unit/filters-test.cxx
@@ -10,26 +10,14 @@
 #include <sal/config.h>
 #include <unotest/filters-test.hxx>
 #include <test/bootstrapfixture.hxx>
-#include <rtl/strbuf.hxx>
-#include <osl/file.hxx>
 #include <com/sun/star/lang/XComponent.hpp>
-#include <com/sun/star/document/XFilter.hpp>
 
-#include <sfx2/app.hxx>
 #include <sfx2/docfilt.hxx>
 #include <sfx2/docfile.hxx>
-#include <sfx2/sfxmodelfactory.hxx>
-#include <svl/stritem.hxx>
-
-#include <svx/svdtext.hxx>
-#include <svx/svdotext.hxx>
 
 #include <drawdoc.hxx>
 #include <DrawDocShell.hxx>
 
-#include <osl/process.h>
-#include <osl/thread.h>
-
 using namespace ::com::sun::star;
 
 /// Test loading of files to assure they do not crash on load.
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 941e27aa2db9..45b4e8836a20 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -21,20 +21,13 @@
 #include <editeng/fhgtitem.hxx>
 #include <editeng/escapementitem.hxx>
 #include <editeng/colritem.hxx>
-#include <editeng/fontitem.hxx>
-#include <editeng/wghtitem.hxx>
 #include <editeng/numitem.hxx>
-#include <editeng/lrspitem.hxx>
-#include <editeng/postitem.hxx>
 #include <editeng/unoprnms.hxx>
 #include <svl/style.hxx>
 
-#include <sfx2/sfxsids.hrc>
 #include <svx/svdotext.hxx>
 #include <svx/svdoashp.hxx>
-#include <svx/svdograf.hxx>
 #include <svx/svdogrp.hxx>
-#include <svx/svdomedia.hxx>
 #include <svx/svdoole2.hxx>
 #include <svx/svdotable.hxx>
 #include <svx/xfillit0.hxx>
@@ -76,6 +69,7 @@
 #include <com/sun/star/chart2/data/XLabeledDataSequence.hpp>
 #include <com/sun/star/chart2/data/XDataSequence.hpp>
 #include <com/sun/star/chart2/data/XNumericalDataSequence.hpp>
+#include <com/sun/star/graphic/XGraphic.hpp>
 #include <com/sun/star/table/BorderLineStyle.hpp>
 #include <com/sun/star/table/BorderLine2.hpp>
 #include <com/sun/star/style/ParagraphAdjust.hpp>
@@ -96,9 +90,6 @@
 #include <vcl/pngread.hxx>
 #include <vcl/bitmapaccess.hxx>
 #include <vcl/dibtools.hxx>
-#include <sfx2/frame.hxx>
-#include <com/sun/star/frame/XModel2.hpp>
-#include <com/sun/star/frame/XController2.hpp>
 
 using namespace ::com::sun::star;
 
diff --git a/sd/qa/unit/misc-tests.cxx b/sd/qa/unit/misc-tests.cxx
index 293f800aaefb..5797bdda4348 100644
--- a/sd/qa/unit/misc-tests.cxx
+++ b/sd/qa/unit/misc-tests.cxx
@@ -10,11 +10,7 @@
 #include <officecfg/Office/Common.hxx>
 #include "sdmodeltestbase.hxx"
 
-#include <vcl/svapp.hxx>
-#include <sddll.hxx>
-
 #include <com/sun/star/uno/Reference.hxx>
-#include <com/sun/star/beans/PropertyValue.hpp>
 
 #include <comphelper/processfactory.hxx>
 #include <com/sun/star/frame/Desktop.hpp>
@@ -34,8 +30,6 @@
 
 #include <vcl/scheduler.hxx>
 #include <osl/thread.hxx>
-#include <FactoryIds.hxx>
-#include <sdmod.hxx>
 #include <svx/sdr/table/tablecontroller.hxx>
 #include <sfx2/request.hxx>
 #include <svx/svdpagv.hxx>
@@ -44,7 +38,6 @@
 #include <editeng/adjustitem.hxx>
 #include <editeng/outlobj.hxx>
 #include <editeng/editobj.hxx>
-#include <ImpressViewShellBase.hxx>
 #include <SlideSorterViewShell.hxx>
 #include <SlideSorter.hxx>
 #include <controller/SlideSorterController.hxx>
diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 8ac645c97765..af443317b94e 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -11,7 +11,6 @@
 #include <app.hrc>
 #include <test/bootstrapfixture.hxx>
 #include <test/helper/transferable.hxx>
-#include <unotest/macros_test.hxx>
 #include <test/xmltesttools.hxx>
 #include <boost/property_tree/json_parser.hpp>
 #include <LibreOfficeKit/LibreOfficeKitEnums.h>
@@ -26,14 +25,12 @@
 #include <editeng/editobj.hxx>
 #include <editeng/editview.hxx>
 #include <editeng/outliner.hxx>
-#include <editeng/fontitem.hxx>
 #include <editeng/fhgtitem.hxx>
 #include <editeng/outlobj.hxx>
 #include <osl/conditn.hxx>
 #include <sfx2/dispatch.hxx>
 #include <sfx2/viewfrm.hxx>
 #include <svl/srchitem.hxx>
-#include <svl/slstitm.hxx>
 #include <svl/stritem.hxx>
 #include <svl/intitem.hxx>
 #include <comphelper/lok.hxx>
@@ -50,7 +47,6 @@
 #include <undo/undomanager.hxx>
 #include <sfx2/request.hxx>
 #include <svx/svxids.hrc>
-#include <DrawViewShell.hxx>
 #include <pres.hxx>
 #include <navigatr.hxx>
 #include <vcl/cursor.hxx>
diff --git a/sd/qa/unit/uimpress.cxx b/sd/qa/unit/uimpress.cxx
index bf6b122f67c9..74678dc7d920 100644
--- a/sd/qa/unit/uimpress.cxx
+++ b/sd/qa/unit/uimpress.cxx
@@ -20,9 +20,6 @@
 #include <sddll.hxx>
 #include <drawdoc.hxx>
 
-#include <iostream>
-#include <vector>
-
 #include <com/sun/star/uno/Reference.hxx>
 #include <com/sun/star/lang/XMultiServiceFactory.hpp>
 #include <com/sun/star/lang/XMultiComponentFactory.hpp>


More information about the Libreoffice-commits mailing list