[Libreoffice-commits] core.git: vcl/source

Miklos Vajna (via logerrit) logerrit at kemper.freedesktop.org
Fri Aug 30 17:07:00 UTC 2019


 vcl/source/window/aboutdialog.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 3779abce2f9562b94f59fc950400081037340096
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Fri Aug 30 17:53:41 2019 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Fri Aug 30 19:06:07 2019 +0200

    tdf#127230 vcl: about dialog double-buffer on macOS is not needed
    
    This was a problem since commit 7eb37a422f2e66bc177d72404c53659a248661ca
    (tdf#118856 vcl: avoid flicker in the about dialog, 2019-08-12).
    
    Given that probably sooner or later this application-level
    double-buffering will not be needed anyway, just do the minimal fix and
    avoid it for the about dialog on macOS.
    
    (Versus low-level double-buffering as macOS, gtk3 or OpenGL does.)
    
    Change-Id: I5dc60e5c064d1e90057f9aa9a22db9f67680eb26
    Reviewed-on: https://gerrit.libreoffice.org/78313
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>
    Tested-by: Jenkins

diff --git a/vcl/source/window/aboutdialog.cxx b/vcl/source/window/aboutdialog.cxx
index 4c8fb048bb9f..879c94d2910f 100644
--- a/vcl/source/window/aboutdialog.cxx
+++ b/vcl/source/window/aboutdialog.cxx
@@ -29,7 +29,9 @@ AboutDialog::AboutDialog(vcl::Window* pParent, WinBits nStyle, Dialog::InitFlag
     m_xBuilder->get(m_xCopyrightText, "copyright");
     m_xBuilder->get(m_xBuildIdLink, "buildIdLink");
 
+#ifndef MACOSX
     m_xVersion->RequestDoubleBuffering(true);
+#endif
 }
 
 void AboutDialog::set_content_area(VclBox* pBox)


More information about the Libreoffice-commits mailing list