[Libreoffice-commits] dev-tools.git: 2 commits - qa/bugzillaChecker.py

[Xisco Fauli (via logerrit)]

 qa/bugzillaChecker.py |   26 +++++++++++++++++---------
 1 file changed, 17 insertions(+), 9 deletions(-)

New commits:
commit ca3b18ba65ec358bb6dbbc1ff2c55bdba42acc75
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Mon Dec 2 14:46:50 2019 +0100
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Mon Dec 2 14:46:50 2019 +0100

    QA: In case it's a regression, change priority to highest

diff --git a/qa/bugzillaChecker.py b/qa/bugzillaChecker.py
index 3916227..c6d3d7f 100755
--- a/qa/bugzillaChecker.py
+++ b/qa/bugzillaChecker.py
@@ -90,14 +90,16 @@ def analyze_bugzilla_checkers(statList, bugzillaData, cfg):
             common.util_check_bugzilla_mail(statList, creatorMail, row['creator_detail']['real_name'], creationDate, rowId)
 
             if common.isOpen(rowStatus) and rowId not in dupesBugs:
-                dupesBugs[rowId] = { 'totalDupes': 0, 'totalCC': len(row['cc']), 'priority': row['priority'], 'severity': row['severity'] }
+                dupesBugs[rowId] = { 'totalDupes': 0, 'totalCC': len(row['cc']), 'priority': row['priority'], 'severity': row['severity'],
+                        'isRegression': 'regression' in rowKeywords }
 
             rowDupeOf = common.util_check_duplicated(bugzillaData, rowId)
             if rowDupeOf and common.isOpen(bugzillaData['bugs'][str(rowDupeOf)]['status']):
                 if rowDupeOf not in dupesBugs:
                     dupesBugs[rowDupeOf] = { 'totalDupes': 0, 'totalCC': len(bugzillaData['bugs'][str(rowDupeOf)]['cc']),
                             'priority': bugzillaData['bugs'][str(rowDupeOf)]['priority'],
-                            'severity': bugzillaData['bugs'][str(rowDupeOf)]['severity'] }
+                            'severity': bugzillaData['bugs'][str(rowDupeOf)]['severity'],
+                            'isRegression': 'regression' in bugzillaData['bugs'][str(rowDupeOf)]['keywords'] }
                 dupesBugs[rowDupeOf]['totalDupes'] += 1
 
             crashSignature = row['cf_crashreport']
@@ -410,9 +412,13 @@ def analyze_bugzilla_checkers(statList, bugzillaData, cfg):
                 value = [k, '', '']
                 util_add_to_result(lResults, 'change_enhancement_priority_to_high', value)
         else:
-            if (v['totalDupes'] >= minNumOfDupes or v['totalCC'] >= minNumOfCC) and (v['priority'] != 'high' and v['priority'] != 'highest'):
-                value = [k, '', '']
-                util_add_to_result(lResults, 'change_bug_priority_to_high', value)
+            if v['totalDupes'] >= minNumOfDupes or v['totalCC'] >= minNumOfCC:
+                if v['isRegression'] and v['priority'] != 'highest':
+                    value = [k, '', '']
+                    util_add_to_result(lResults, 'change_bug_priority_to_highest', value)
+                elif (v['priority'] != 'high' and v['priority'] != 'highest'):
+                    value = [k, '', '']
+                    util_add_to_result(lResults, 'change_bug_priority_to_high', value)
 
     fp = open(bugzillaReportPath, 'w', encoding='utf-8')
     print("Creating file " + bugzillaReportPath)
commit cf7bfbffe1ad55710a2696a2741328686ba0b80b
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Mon Dec 2 14:23:21 2019 +0100
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Mon Dec 2 14:23:21 2019 +0100

    QA: Also check for number of people in CC

diff --git a/qa/bugzillaChecker.py b/qa/bugzillaChecker.py
index 0c7edff..3916227 100755
--- a/qa/bugzillaChecker.py
+++ b/qa/bugzillaChecker.py
@@ -49,6 +49,7 @@ versionsToCheck = ('5', '6')
 crashReportDomain = "https://crashreport.libreoffice.org/stats/signature/"
 
 minNumOfDupes = 5
+minNumOfCC = 20
 
 def util_create_statList_checkers():
     return {
@@ -89,14 +90,15 @@ def analyze_bugzilla_checkers(statList, bugzillaData, cfg):
             common.util_check_bugzilla_mail(statList, creatorMail, row['creator_detail']['real_name'], creationDate, rowId)
 
             if common.isOpen(rowStatus) and rowId not in dupesBugs:
-                dupesBugs[rowId] = { 'total': 0, 'priority': row['priority'], 'severity': row['severity'] }
+                dupesBugs[rowId] = { 'totalDupes': 0, 'totalCC': len(row['cc']), 'priority': row['priority'], 'severity': row['severity'] }
 
             rowDupeOf = common.util_check_duplicated(bugzillaData, rowId)
             if rowDupeOf and common.isOpen(bugzillaData['bugs'][str(rowDupeOf)]['status']):
                 if rowDupeOf not in dupesBugs:
-                    dupesBugs[rowDupeOf] = { 'total': 0, 'priority': bugzillaData['bugs'][str(rowDupeOf)]['priority'],
+                    dupesBugs[rowDupeOf] = { 'totalDupes': 0, 'totalCC': len(bugzillaData['bugs'][str(rowDupeOf)]['cc']),
+                            'priority': bugzillaData['bugs'][str(rowDupeOf)]['priority'],
                             'severity': bugzillaData['bugs'][str(rowDupeOf)]['severity'] }
-                dupesBugs[rowDupeOf]['total'] += 1
+                dupesBugs[rowDupeOf]['totalDupes'] += 1
 
             crashSignature = row['cf_crashreport']
             if crashSignature:
@@ -401,14 +403,14 @@ def analyze_bugzilla_checkers(statList, bugzillaData, cfg):
 
     for k, v in dupesBugs.items():
         if v['severity'] == 'enhancement':
-            if v['total'] < minNumOfDupes and (v['priority'] == 'high' or v['priority'] == 'highest'):
+            if v['totalDupes'] < minNumOfDupes and v['totalCC'] < minNumOfCC and (v['priority'] == 'high' or v['priority'] == 'highest'):
                 value = [k, '', '']
                 util_add_to_result(lResults, 'change_enhancement_priority_to_medium', value)
-            elif v['total'] >= minNumOfDupes and (v['priority'] != 'high' and v['priority'] != 'highest'):
+            elif (v['totalDupes'] >= minNumOfDupes or v['totalCC'] >= minNumOfCC) and (v['priority'] != 'high' and v['priority'] != 'highest'):
                 value = [k, '', '']
                 util_add_to_result(lResults, 'change_enhancement_priority_to_high', value)
         else:
-            if v['total'] >= minNumOfDupes and (v['priority'] != 'high' and v['priority'] != 'highest'):
+            if (v['totalDupes'] >= minNumOfDupes or v['totalCC'] >= minNumOfCC) and (v['priority'] != 'high' and v['priority'] != 'highest'):
                 value = [k, '', '']
                 util_add_to_result(lResults, 'change_bug_priority_to_high', value)