[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - scaddins/inc

Julien Nabet (via logerrit) logerrit at kemper.freedesktop.org
Wed Dec 4 22:23:17 UTC 2019


 scaddins/inc/pricing.hrc |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit b414e1b9fc428279bfd4258537f0a1d2de2a343b
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Fri Nov 29 17:47:15 2019 +0100
Commit:     Eike Rathke <erack at redhat.com>
CommitDate: Wed Dec 4 23:22:32 2019 +0100

    tdf#129098: parameters mixed in OPT_PROB_INMONEY (scaddins)
    
    Here's getOptProbInMoney signature according to XPricingFunctions.idl:
    66         /// OPT_PROB_INMONEY(), probability of ending up in-the-money.
    67         double getOptProbInMoney( [in] double spot, [in] double vol,
    68             [in] double mu, [in] double maturity,
    69             [in] double barrierLow, [in] double barrierUp,
    70             [in] any strike, [in] any putCall )
    71             raises( com::sun::star::lang::IllegalArgumentException );
    So "putCall" should be at the end.
    
    It's been like this since initial commit:
    https://cgit.freedesktop.org/libreoffice/core/commit/?id=e9f31eaa49f9494113e72deaf0fe079701844ea4
    
    Change-Id: I186348fe7470633abd32598954b7032102770a8a
    Reviewed-on: https://gerrit.libreoffice.org/84078
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    (cherry picked from commit b1832658951d9f03c871b665b270a73deacf884f)
    Reviewed-on: https://gerrit.libreoffice.org/84089
    Reviewed-by: Eike Rathke <erack at redhat.com>

diff --git a/scaddins/inc/pricing.hrc b/scaddins/inc/pricing.hrc
index 0a13edb59a4e..c4c9a27913bc 100644
--- a/scaddins/inc/pricing.hrc
+++ b/scaddins/inc/pricing.hrc
@@ -113,10 +113,10 @@ const char* PRICING_FUNCDESC_OptProbInMoney[] =
     NC_("PRICING_FUNCDESC_OptProbInMoney", "Lower barrier (set to 0 for no lower barrier)"),
     NC_("PRICING_FUNCDESC_OptProbInMoney", "barrier_up"),
     NC_("PRICING_FUNCDESC_OptProbInMoney", "Upper barrier (set to 0 for no upper barrier)"),
-    NC_("PRICING_FUNCDESC_OptProbInMoney", "put/call"),
-    NC_("PRICING_FUNCDESC_OptProbInMoney", "Optional (p)ut/(c)all indicator"),
     NC_("PRICING_FUNCDESC_OptProbInMoney", "strike"),
-    NC_("PRICING_FUNCDESC_OptProbInMoney", "Optional strike level")
+    NC_("PRICING_FUNCDESC_OptProbInMoney", "Optional strike level"),
+    NC_("PRICING_FUNCDESC_OptProbInMoney", "put/call"),
+    NC_("PRICING_FUNCDESC_OptProbInMoney", "Optional (p)ut/(c)all indicator")
 };
 
 #endif


More information about the Libreoffice-commits mailing list