[Libreoffice-commits] core.git: sd/inc sd/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Thu Dec 5 20:02:59 UTC 2019


 sd/inc/sdabstdlg.hxx          |    2 +-
 sd/source/ui/inc/drawview.hxx |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 86f148afbb8b476d22f92632c619f1b94f0b2102
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Dec 5 16:53:29 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Dec 5 21:01:37 2019 +0100

    CppunitTest_sd_dialogs_test still needs some symbols as SD_DLLPUBLIC
    
    ...after e189a3f5b5c4f381dcf109eb9a2ee9b6d32d5551 "make some classes module
    private":
    
    > [LNK] CppunitTest/libtest_sd_dialogs_test.so
    > sd/qa/unit/dialogs-test.cxx:107: error: undefined reference to 'SdAbstractDialogFactory::Create()'
    > sd/qa/unit/dialogs-test.cxx:160: error: undefined reference to 'typeinfo for sd::DrawView'
    
    Change-Id: Ib173d576bfe3c59c31229bb769999693d8ec9d57
    Reviewed-on: https://gerrit.libreoffice.org/84575
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sd/inc/sdabstdlg.hxx b/sd/inc/sdabstdlg.hxx
index 3f77b5efd3b5..eebe5695748d 100644
--- a/sd/inc/sdabstdlg.hxx
+++ b/sd/inc/sdabstdlg.hxx
@@ -169,7 +169,7 @@ protected:
 class SdAbstractDialogFactory
 {
 public:
-    static SdAbstractDialogFactory*     Create();
+    SD_DLLPUBLIC static SdAbstractDialogFactory*     Create();
 
     virtual VclPtr<AbstractSvxBulletAndPositionDlg> CreateSvxBulletAndPositionDlg(weld::Window* pParent, const SfxItemSet* pAttr, ::sd::View* pView) = 0;
     virtual VclPtr<VclAbstractDialog>          CreateBreakDlg(weld::Window* pWindow, ::sd::DrawView* pDrView, ::sd::DrawDocShell* pShell, sal_uLong nSumActionCount, sal_uLong nObjCount ) = 0;
diff --git a/sd/source/ui/inc/drawview.hxx b/sd/source/ui/inc/drawview.hxx
index 34360c61c772..2d41de1af250 100644
--- a/sd/source/ui/inc/drawview.hxx
+++ b/sd/source/ui/inc/drawview.hxx
@@ -30,7 +30,7 @@ class DrawViewShell;
 /**
  * Derivative of ::sd::View; contains also a pointer to the document
  */
-class DrawView : public ::sd::View
+class SD_DLLPUBLIC DrawView : public ::sd::View
 {
 public:
 


More information about the Libreoffice-commits mailing list