[Libreoffice-commits] core.git: sfx2/source

Marco Cecchetti (via logerrit) logerrit at kemper.freedesktop.org
Tue Dec 10 13:52:09 UTC 2019


 sfx2/source/view/ipclient.cxx |   11 -----------
 1 file changed, 11 deletions(-)

New commits:
commit c00eda32d18eab7fd88606b1c30bfcf05b7ee0a4
Author:     Marco Cecchetti <marco.cecchetti at collabora.com>
AuthorDate: Tue Oct 8 12:09:21 2019 +0200
Commit:     Andras Timar <andras.timar at collabora.com>
CommitDate: Tue Dec 10 14:51:11 2019 +0100

    lok: re-enabling chart editing on mobile
    
    Change-Id: I0e05cc2c41ba045e62ad87203f7000f2b568add3
    Reviewed-on: https://gerrit.libreoffice.org/81916
    Tested-by: Jenkins
    Reviewed-by: Andras Timar <andras.timar at collabora.com>

diff --git a/sfx2/source/view/ipclient.cxx b/sfx2/source/view/ipclient.cxx
index ea73e08b0bfb..289ed49e9194 100644
--- a/sfx2/source/view/ipclient.cxx
+++ b/sfx2/source/view/ipclient.cxx
@@ -952,17 +952,6 @@ ErrCode SfxInPlaceClient::DoVerb( long nVerb )
                 {
                     m_xImp->m_xObject->setClientSite( m_xImp->m_xClient );
 
-                    // Disable embedded object editing (e.g. chart) on mobile
-                    if ( comphelper::LibreOfficeKit::isActive() && comphelper::LibreOfficeKit::isMobile(SfxLokHelper::getView())
-                            && m_xImp->m_xObject->getCurrentState() == embed::EmbedStates::RUNNING )
-                    {
-                        // Also check next state
-                        // Needs to be embed::EmbedStates::UI_ACTIVE or embed::EmbedStates::INPLACE_ACTIVE
-                        // Conversion table is in embeddedobj/source/commonembedding/miscobj.cxx
-                        if (nVerb != embed::EmbedVerbs::MS_OLEVERB_OPEN && nVerb != embed::EmbedVerbs::MS_OLEVERB_HIDE)
-                            return nError;
-                    }
-
                     m_xImp->m_xObject->doVerb( nVerb );
                 }
                 catch ( embed::UnreachableStateException& )


More information about the Libreoffice-commits mailing list