[Libreoffice-commits] core.git: Changes to 'feature/jssidebar'

Mon Dec 16 12:14:32 UTC 2019

New branch 'feature/jssidebar' available with the following commits:
commit 523a7b6d5f2989703c0dce03986f6676f300a501
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Sun Dec 15 21:12:17 2019 -0500

    sfx2: sidebar: new .uno commands to show and hide sidebars
    
    Change-Id: I9afba5eec855d6de590086736177b543d52d3b20
    Reviewed-on: https://gerrit.libreoffice.org/85192
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

commit 0345a87166ade9cd0f787af0b5dbe984b92735fd
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Wed Dec 11 18:19:43 2019 -0500

    chart2: clear listener parents in dispose
    
    Change-Id: Icdab125589ab0f55255f683a1ea39e036de661b1
    Reviewed-on: https://gerrit.libreoffice.org/84997
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit 05314e84d2d7ad8e447cba3971ab518b96ef3fe9
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Wed Dec 11 12:23:08 2019 -0500

    sfx2: sidebar: notify mobile when the sidebar closes
    
    Change-Id: Idb05346a9ccc8690cad566b74ec86d5fdd3bfb35
    Reviewed-on: https://gerrit.libreoffice.org/84973
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit 880fac6f55b6cc1a9c49dfe6f7d194cd88c7c506
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Sun Dec 8 12:36:58 2019 -0500

    sidebar: sensible line and page sizes and invalidate
    
    Change-Id: Icf60480a47d7c93bad44f6457bb05af332e63c6d
    Reviewed-on: https://gerrit.libreoffice.org/84718
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit c10dba8f4024a63bc85e2070c0646b3e0985e74a
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Wed Dec 4 08:19:22 2019 -0500

    LOK: don't send LOK notifications while switching views
    
    Changing the active view is done for virtually every
    LOK API, and in some cases simply changing the view
    results in a flurry of notifications that themselves
    caues further API calls that need to change the view.
    
    This moves the disabling of callbacks during setView
    to SfxLokHelper to make sure no view gets any
    notifications. This is needed because even when
    we disable notifications for the current view,
    the _other_ view(s) can still get notified as they
    lose their frame.
    
    Change-Id: Ia88a58d6a1162e48c40f4c4ce73c40ecb2c1fb7e
    Reviewed-on: https://gerrit.libreoffice.org/84417
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
    Tested-by: Ashod Nakashian <ashnakash at gmail.com>

commit 03faa0ef6035f2cfba5dcba19e179c749b0385c6
Author: Szymon Kłos <szymon.klos at collabora.com>
Date:   Tue Dec 3 17:31:08 2019 +0100

    jsdialogs: make possible to use on multiple mobile devices
    
    Change-Id: I1f7867dfd15e423f10622b3cec17ed8039d23c49
    Reviewed-on: https://gerrit.libreoffice.org/84367
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>

commit a6e4b3562675f65803149fba2c2d4eafffcb5fc8
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Tue Dec 3 09:23:27 2019 -0500

    sidebar: always trigger LOK notifications on resize
    
    This is critical for the Mobile Wizard, which
    refreshes by pushing, not pulling (following invalidations).
    
    Change-Id: Ie75c2f5c07798fa89c21901d6d0233c42768ea8d
    Reviewed-on: https://gerrit.libreoffice.org/84359
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
    Tested-by: Ashod Nakashian <ashnakash at gmail.com>

commit 70bf872b426dd51d972e06f566252864bb02504d
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Fri May 24 09:11:11 2019 -0400

    sfx2: LOK: disable the Reset button from tabbed dialogs
    
    The reset functionality seems to be confusing to more
    than one user. Their expectation isn't always matching
    the functionality, perhaps because it has rough edges(?).
    
    Disabling for LOK to avoid this; users can Cancel
    and start over if they wish to do (which is what the
    Reset button is supposed to do in effect).
    
    (cherry picked from commit c3c28235cf1f853e644250ba110b2715a270a8b5)
    
    Change-Id: I4a744dd0263ab72a5858746c1f3572e62990a13b
    Reviewed-on: https://gerrit.libreoffice.org/83630
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit e5afef8731817800cba7d3e71e980e4b7dbd8456
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Sun Nov 24 09:56:02 2019 -0500

    sidebar: do not emit unnecessary created notifications
    
    This also breaks a potentially recursive cycle where
    each 'created' notification requests a re-rendering,
    which triggers view change (when more than one view
    is open on the doc), which triggers a frame change,
    which resets the sidebar, causing a 'created'
    notification, thereby starting the cycle anew.
    
    Change-Id: I1aafe7f45871748afb393fa55c357037215e6c33
    Reviewed-on: https://gerrit.libreoffice.org/83629
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit 06b44b01029935182dd3e808cd6d1407652bafeb
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Fri Nov 22 21:07:21 2019 -0500

    sidebar: reset the LOKNotifier when the ViewShell changes
    
    The ViewShell (which implements the LOKNotifier interface)
    changes during the lifetime of the SidebarDockingWindow.
    This is extremely problematic, because we assign the
    LOKNotifier to a window, and use it to emit notifications
    to the LOKit clients. When the ViewShell changes, a window
    (the SidebarDockingWindow in this case) may end up using
    an old ViewShell instance, which may have just been destroyed.
    
    Now we properly reset the LOKNotifier to make sure we are
    using the current ViewShell at all times. This is still
    not ideal, since we may use the wrong ViewShell to send
    out notifications, but we can't control that as we are at
    the mercy of the mechanism that changes the current ViewShell.
    
    This also removes obsolete flags to control which
    document-types supported sidebar, as well as other misc
    cleanups.
    
    Change-Id: Ic208f64596a39feb7354958cf4d5e1e033d87b5b
    Reviewed-on: https://gerrit.libreoffice.org/83627
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit d2f1db2515efabba7bf6949ad37cb28ade4bc7e7
Author: Szymon Kłos <szymon.klos at collabora.com>
Date:   Wed Nov 20 16:10:33 2019 +0100

    jsdialogs: simply resize to reload
    
    Change-Id: I4eaee0f1ec27674d74fc7abfa05abaf39cb97117
    Reviewed-on: https://gerrit.libreoffice.org/83326
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>

commit d201ac66eebfd9de3797ad17271d11a03b2ac3fc
Author: Szymon Kłos <szymon.klos at collabora.com>
Date:   Tue Nov 19 17:59:17 2019 +0200

    Revert "jsdialogs: don't recreate sidebar on event"
    
    This reverts commit 0c75ccd84ea64f2c69afe104a4b4ebd55b3cc215.
    
    Change-Id: I127cd0179d24af52f695c9f1ee0792b9573e6e0e
    Reviewed-on: https://gerrit.libreoffice.org/83219
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>

commit bd0c5ca018b0a085c15e80dee53c615456de97fa
Author: Szymon Kłos <szymon.klos at collabora.com>
Date:   Thu Nov 14 12:05:11 2019 +0100

    jsdialogs: don't recreate sidebar on event
    
    This will allow to use mobile wizard in multiple views.
    JS listeners on uno commands are used instead. Also
    vcl events broadcasting is needed.
    
    Change-Id: Iddb230bfcf899384749d92da359b0a6a1260bc9f
    Reviewed-on: https://gerrit.libreoffice.org/82669
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>

commit feab811d8808fd48c39a430f86c1cc605d22d0cb
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Sun Nov 11 23:35:03 2018 -0500

    sd: for_each -> range-for
    
    Simpler, more readable, and sensible stacktraces.
    
    Change-Id: I8e8a9903e3bf2ce5f31b841db9cb68fe4edc3fb6
    (cherry picked from commit a00490bf0d2ee2c94f494978ebfeb8012a02e678)
    Reviewed-on: https://gerrit.libreoffice.org/82403
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
    Tested-by: Ashod Nakashian <ashnakash at gmail.com>
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>

commit c3a279f775d10e912bdf470d15c0e4b0d604b519
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Thu Oct 31 07:26:34 2019 -0400

    sidebar: check for valid current deck before closing
    
    Also, cleanup unused/unnecessary LOKNotifier logic
    from Deck.cxx and use emplace_back where possible.
    
    Change-Id: I300c5158b12593e8130f5b6273c1ea3bcbefea7f
    Reviewed-on: https://gerrit.libreoffice.org/82402
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
    Tested-by: Ashod Nakashian <ashnakash at gmail.com>

commit 2b95fd83bf1bd238031fa1f637d416eaf0aec9b4
Author: Szymon Kłos <szymon.klos at collabora.com>
Date:   Wed Nov 6 19:13:12 2019 +0100

    jsdialogs: refresh after event
    
    Change-Id: Ie0128ec38dd442a04d6ea9e24cea254f5bc69791
    Reviewed-on: https://gerrit.libreoffice.org/82170
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

commit a5c2a6d6bb0f6ea1c377ea8bf922c08df60fb0c3
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Wed Oct 30 06:12:26 2019 -0400

    sidebars: add JSDialog support to sidebars
    
    Currently the JSDialog path is only for mobile
    and we use the passive notifications for desktop
    Online.
    
    Change-Id: I5d26fee9475ede665f269ca1f7b582455be08e50
    Reviewed-on: https://gerrit.libreoffice.org/81754
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit 7d6c89501ae33750e7e25b4e78e4334efe98745a
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Mon Dec 16 11:48:06 2019 +0000

    Revert "jsdialogs: send JSON to the client"
    
    This reverts commit 8f5f2ec5d1055f2bb81ad05e23280c51f5e6eb27.
    
    Change-Id: I8420813797352a3ab6a00adfb484170c75619b0c

commit eae26dbee44f88da739362aa8d126c97f5afb600
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Mon Dec 16 11:45:37 2019 +0000

    Revert "lok: only generate sidebar JSON for mobile views, for now."
    
    This reverts commit 2d7d3cc936cb5b0a242ad7a5c714ebde03df574d.

commit b518264708d56ceb392cdd1aa567d3cd2941ebec
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Mon Dec 16 11:45:17 2019 +0000

    Revert "jsdialogs: emit JSON at idle to avoid repeated emission."
    
    This reverts commit 7d9932ade30464abf297f2e3c3690cca68d6bf71.

commit 05f82d1ae7410fb256a9b5eec3610979aa05a47e
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Mon Dec 16 11:44:25 2019 +0000

    Revert "jsdialogs: set LOKNotifier in Deck"
    
    This reverts commit 5db9bfee77e560c46457a40aee3d2b0752ab2fd8.