[Libreoffice-commits] core.git: sc/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Mon Dec 16 12:51:13 UTC 2019


 sc/source/ui/docshell/externalrefmgr.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ba2be3187e59758ed31ceeb522f58d5796bcb97c
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Mon Dec 16 10:48:11 2019 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Mon Dec 16 13:50:29 2019 +0100

    crashtesting: null deref on load of tdf113898-2.ods
    
    Change-Id: Ie6e00af220d1ee65c363224abcf63ece2e7bff6f
    Reviewed-on: https://gerrit.libreoffice.org/85206
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/ui/docshell/externalrefmgr.cxx b/sc/source/ui/docshell/externalrefmgr.cxx
index 577823b3b0a2..56273f1b6c99 100644
--- a/sc/source/ui/docshell/externalrefmgr.cxx
+++ b/sc/source/ui/docshell/externalrefmgr.cxx
@@ -2004,7 +2004,7 @@ ScExternalRefCache::TokenArrayRef ScExternalRefManager::getDoubleRefTokens(
     if (!pSrcDoc)
     {
         // Source document is not reachable.  Throw a reference error.
-        pArray.reset(new ScTokenArray(pSrcDoc));
+        pArray.reset(new ScTokenArray(maRefCache.getFakeDoc()));
         pArray->AddToken(FormulaErrorToken(FormulaError::NoRef));
         return pArray;
     }


More information about the Libreoffice-commits mailing list