[Libreoffice-commits] core.git: basic/source

[Stephan Bergmann (via logerrit)]

 basic/source/basmgr/basicmanagerrepository.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4af97bd05aa5caa873c46b5c27aad48af23464b5
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue Dec 17 13:32:16 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue Dec 17 14:44:23 2019 +0100

    No need to leak ImplRepository
    
    ...after 919689ac876eb051f01a09ef67e8140efaa3df32 "Remove unused preliminary
    entries from ImplRepository::m_aStore again" makes sure ImplRepository::m_aStore
    doesn't accumulate references to UNO objects, which would only have been
    destroyed upon exit, at which point that would easily have caused various
    issues.
    
    Change-Id: I6338a1ff46d72c137d619eabd8facca794028324
    Reviewed-on: https://gerrit.libreoffice.org/85296
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/basic/source/basmgr/basicmanagerrepository.cxx b/basic/source/basmgr/basicmanagerrepository.cxx
index 3c0be766afc0..c493da8bd29d 100644
--- a/basic/source/basmgr/basicmanagerrepository.cxx
+++ b/basic/source/basmgr/basicmanagerrepository.cxx
@@ -204,8 +204,8 @@ namespace basic
     {
         ImplRepository* operator()()
         {
-            static ImplRepository* pRepository = new ImplRepository;
-            return pRepository;
+            static ImplRepository repository;
+            return &repository;
         }
     };