[Libreoffice-commits] core.git: writerfilter/source

Justin Luth (via logerrit) logerrit at kemper.freedesktop.org
Sat Dec 21 09:37:29 UTC 2019


 writerfilter/source/dmapper/DomainMapper_Impl.hxx |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

New commits:
commit fa3cb1a31ef0bbe9ebc8ab8a79463c7f4d760d89
Author:     Justin Luth <justin.luth at collabora.com>
AuthorDate: Sat Dec 21 09:00:51 2019 +0300
Commit:     Justin Luth <justin_luth at sil.org>
CommitDate: Sat Dec 21 10:36:05 2019 +0100

    nitpick tdf#123262 writefilter: use enum class and document
    
    Change-Id: Ibc040c75fff309699911ffa72d1f44ce5b231688
    Reviewed-on: https://gerrit.libreoffice.org/85644
    Tested-by: Jenkins
    Reviewed-by: Justin Luth <justin_luth at sil.org>

diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index f3f9f77ce1cf..cdbc2f8a80c2 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
@@ -114,7 +114,16 @@ enum BreakType
     COLUMN_BREAK
 };
 
-enum SkipFootnoteSeparator
+/**
+ * Two special footnotes are a separator line, and a continuation line.
+ * In MSOffice, these can contain text as well, but LO doesn't implement this
+ * rarely used feature, so the separator text needs to be skipped. (tdf#123262)
+ * Three-way logic is needed because there is no guaranteed on-off event.
+ * OFF == not in footnote separator
+ * ON == in footnote separator
+ * SKIPPING == ON status has been recognized.
+ */
+enum class SkipFootnoteSeparator
 {
     OFF,
     ON,


More information about the Libreoffice-commits mailing list