[Libreoffice-commits] core.git: vcl/source

Ashod Nakashian (via logerrit) logerrit at kemper.freedesktop.org
Mon Dec 23 01:01:23 UTC 2019


 vcl/source/window/floatwin.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 15df500cb0a7166eb20104b254db963f74cb5144
Author:     Ashod Nakashian <ashod.nakashian at collabora.co.uk>
AuthorDate: Wed Dec 18 07:30:14 2019 -0500
Commit:     Ashod Nakashian <ashnakash at gmail.com>
CommitDate: Mon Dec 23 02:00:13 2019 +0100

    vcl: don't use null window in FloatingWindow HitTest
    
    Change-Id: I551f31cf30c7a58642becebe0256684055d0703a
    Reviewed-on: https://gerrit.libreoffice.org/85383
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
    Tested-by: Ashod Nakashian <ashnakash at gmail.com>
    (cherry picked from commit 65685bac09a4320602f4dda5151d247c5a83a75c)
    Reviewed-on: https://gerrit.libreoffice.org/85402
    Tested-by: Jenkins

diff --git a/vcl/source/window/floatwin.cxx b/vcl/source/window/floatwin.cxx
index d846cba8ddd4..8f18936d0ff0 100644
--- a/vcl/source/window/floatwin.cxx
+++ b/vcl/source/window/floatwin.cxx
@@ -522,6 +522,8 @@ FloatingWindow* FloatingWindow::ImplFloatHitTest( vcl::Window* pReference, const
 
         // use the border window to have the exact position
         vcl::Window *pBorderWin = pWin->GetWindow( GetWindowType::Border );
+        if (!pBorderWin)
+            break;
 
         // the top-left corner in output coordinates ie (0,0)
         tools::Rectangle devRect( pBorderWin->ImplOutputToUnmirroredAbsoluteScreenPixel( tools::Rectangle( Point(), pBorderWin->GetSizePixel()) ) ) ;


More information about the Libreoffice-commits mailing list