[Libreoffice-commits] core.git: chart2/source

Muhammet Kara (via logerrit) logerrit at kemper.freedesktop.org
Tue Dec 31 14:28:38 UTC 2019


 chart2/source/controller/sidebar/ChartColorWrapper.cxx |    6 ------
 1 file changed, 6 deletions(-)

New commits:
commit 8a3ed4d2835bf441c578d480a8cc8f2c31231996
Author:     Muhammet Kara <muhammet.kara at collabora.com>
AuthorDate: Mon Dec 30 16:14:20 2019 +0300
Commit:     Muhammet Kara <muhammet.kara at collabora.com>
CommitDate: Tue Dec 31 15:28:07 2019 +0100

    Restore mxModel invariant in ChartColorWrapper::operator()
    
    As per discussion on https://gerrit.libreoffice.org/c/core/+/85111
    
    Change-Id: I2cebe65ef8a03da95527ce882e7538f958fcdfbb
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85995
    Tested-by: Jenkins
    Reviewed-by: Muhammet Kara <muhammet.kara at collabora.com>

diff --git a/chart2/source/controller/sidebar/ChartColorWrapper.cxx b/chart2/source/controller/sidebar/ChartColorWrapper.cxx
index 31808b1a292b..5b0654b2d86b 100644
--- a/chart2/source/controller/sidebar/ChartColorWrapper.cxx
+++ b/chart2/source/controller/sidebar/ChartColorWrapper.cxx
@@ -72,12 +72,6 @@ ChartColorWrapper::ChartColorWrapper(
 
 void ChartColorWrapper::operator()(const OUString& , const NamedColor& rColor)
 {
-    if (!mxModel.is())
-    {
-        SAL_WARN("chart2", "Invalid reference to mxModel");
-        return;
-    }
-
     css::uno::Reference<css::beans::XPropertySet> xPropSet = getPropSet(mxModel);
 
     if (!xPropSet.is())


More information about the Libreoffice-commits mailing list