[Libreoffice-commits] core.git: test/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Feb 1 12:13:23 UTC 2019


 test/source/xmltesttools.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 9808486a89c6368f836579f8d8c0dda63fd0063c
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Feb 1 12:01:58 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Fri Feb 1 13:12:57 2019 +0100

    Avoid -Werror,-Wimplicit-fallthrough with clang-cl
    
    ...where CPPUNIT_FAIL is marked as noreturn only for __GNUC__
    
    Change-Id: Id820b00d8dfe1218a10cd586d32cc20eb6a003de
    Reviewed-on: https://gerrit.libreoffice.org/67244
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/test/source/xmltesttools.cxx b/test/source/xmltesttools.cxx
index 00d156c40ecf..b104599f4b9d 100644
--- a/test/source/xmltesttools.cxx
+++ b/test/source/xmltesttools.cxx
@@ -11,6 +11,7 @@
 
 #include <memory>
 
+#include <o3tl/unreachable.hxx>
 #include <vcl/mtfxmldump.hxx>
 
 namespace {
@@ -96,6 +97,7 @@ OUString XmlTestTools::getXPathContent(xmlDocPtr pXmlDoc, const OString& rXPath)
     {
         case XPATH_UNDEFINED:
             CPPUNIT_FAIL("Undefined XPath type");
+            O3TL_UNREACHABLE;
         case XPATH_NODESET:
         {
             xmlNodeSetPtr pXmlNodes = pXmlObj->nodesetval;


More information about the Libreoffice-commits mailing list