[Libreoffice-commits] online.git: loleaflet/src

[Libreoffice Gerrit user]

 loleaflet/src/core/Socket.js |    5 +++++
 1 file changed, 5 insertions(+)

New commits:
commit a6e1aa9d362af06c202126d50cad4b5e2114ac9a
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Tue Feb 5 16:47:32 2019 +0200
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Tue Feb 5 16:48:25 2019 +0200

    Add a FIXME
    
    Change-Id: Ia6dccf3fe23e0a4bfd40f4ce2dee168311554418

diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index a5b3abf90..7a96445e9 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -738,6 +738,11 @@ L.Socket = L.Class.extend({
 
 			// Decode UTF-8 in case it is binary frame
 			if (typeof e.data === 'object') {
+				// FIXME: Not sure what this code is supposed to do. Doesn't
+				// decodeURIComponent() exactly reverse what window.escape() (which
+				// is a deprecated equivalent of encodeURIComponent()) does? In what
+				// case is this code even hit? If somebody figures out what is going
+				// on here, please replace this comment with an explanation.
 				textMsg = decodeURIComponent(window.escape(textMsg));
 			}
 		}