[Libreoffice-commits] core.git: sc/qa

[Libreoffice Gerrit user]

 sc/qa/uitest/chart/tdf46885.py |   60 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

New commits:
commit c3cfe8f787a659eb6a18bd87cc47e9daa26cec4b
Author:     Zdeněk Crhonek <zcrhonek at gmail.com>
AuthorDate: Wed Feb 6 21:02:18 2019 +0100
Commit:     Zdenek Crhonek <zcrhonek at gmail.com>
CommitDate: Wed Feb 6 21:50:48 2019 +0100

    uitest for bug tdf#46885
    
    Bug 46885 - LibO crash when creating chart with no cells selected
    
    Change-Id: Iebe582863c2330579087d3d2743bca5d2d1676f6
    Reviewed-on: https://gerrit.libreoffice.org/67472
    Tested-by: Jenkins
    Reviewed-by: Zdenek Crhonek <zcrhonek at gmail.com>

diff --git a/sc/qa/uitest/chart/tdf46885.py b/sc/qa/uitest/chart/tdf46885.py
new file mode 100644
index 000000000000..cf49539f8f4a
--- /dev/null
+++ b/sc/qa/uitest/chart/tdf46885.py
@@ -0,0 +1,60 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+import org.libreoffice.unotest
+import pathlib
+
+def get_url_for_data_file(file_name):
+    return pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+
+#Bug 46885 - LibO crash when creating chart with no cells selected
+
+class tdf46885(UITestCase):
+    def test_tdf46885_crash_chart_no_cell_selected_nextButton(self):
+        calc_doc = self.ui_test.create_doc_in_start_center("calc")
+        xCalcDoc = self.xUITest.getTopFocusWindow()
+        gridwin = xCalcDoc.getChild("grid_window")
+        document = self.ui_test.get_component()
+        enter_text_to_cell(gridwin, "A10", "col1")
+        #When you start a new chart and have one empty cell selected LibO will crash when you select the Next>> button.
+        self.ui_test.execute_dialog_through_command(".uno:InsertObjectChart")
+        xChartDlg = self.xUITest.getTopFocusWindow()
+        xNextBtn = xChartDlg.getChild("next")
+        xNextBtn.executeAction("CLICK", tuple())
+        xOkBtn = xChartDlg.getChild("finish")
+        self.ui_test.close_dialog_through_button(xOkBtn)
+
+        #verify, we didn't crash
+        self.assertEqual(get_cell_by_position(document, 0, 0, 9).getString(), "col1")
+
+        self.ui_test.close_doc()
+
+    def test_tdf46885_crash_chart_multiple_empty_cells_selected(self):
+        calc_doc = self.ui_test.create_doc_in_start_center("calc")
+        xCalcDoc = self.xUITest.getTopFocusWindow()
+        gridwin = xCalcDoc.getChild("grid_window")
+        document = self.ui_test.get_component()
+        enter_text_to_cell(gridwin, "A10", "col1")
+        #If you select multiple empty cells and then start a new chart LibO will crash immediately.
+        gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": "A1:C4"}))
+        self.ui_test.execute_dialog_through_command(".uno:InsertObjectChart")
+        xChartDlg = self.xUITest.getTopFocusWindow()
+        xNextBtn = xChartDlg.getChild("next")
+        xNextBtn.executeAction("CLICK", tuple())
+        xOkBtn = xChartDlg.getChild("finish")
+        self.ui_test.close_dialog_through_button(xOkBtn)
+
+        #verify, we didn't crash
+        self.assertEqual(get_cell_by_position(document, 0, 0, 9).getString(), "col1")
+
+        self.ui_test.close_doc()
+# vim: set shiftwidth=4 softtabstop=4 expandtab: