[Libreoffice-commits] core.git: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Feb 8 16:26:30 UTC 2019


 sc/source/ui/view/viewfunc.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8e1e0246a5a33d9206d6310cf8a135c2cccd70f5
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Fri Feb 8 15:05:33 2019 +0300
Commit:     Marco Cecchetti <mrcekets at gmail.com>
CommitDate: Fri Feb 8 17:26:03 2019 +0100

    tdf#120703 PVS: fix condition
    
    V560 A part of conditional expression is always false:
         nY == nStartRow.
    
    Change-Id: I2d1a809400d48889780ce320be740648f8d9b97f
    Reviewed-on: https://gerrit.libreoffice.org/67541
    Tested-by: Jenkins
    Reviewed-by: Marco Cecchetti <mrcekets at gmail.com>

diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx
index cc9733a52c2b..12b78243c34d 100644
--- a/sc/source/ui/view/viewfunc.cxx
+++ b/sc/source/ui/view/viewfunc.cxx
@@ -1559,7 +1559,7 @@ void ScViewFunc::OnLOKInsertDeleteRow(SCROW nStartRow, long nOffset)
                 else
                 {
                     SCROW nY = pTabViewShell->GetViewData().GetCurYForTab(nCurrentTabIndex);
-                    if (nY >= nStartRow || (nY == nStartRow && nOffset > 0))
+                    if (nY > nStartRow || (nY == nStartRow && nOffset > 0))
                     {
                         pTabViewShell->GetViewData().SetCurYForTab(nY + nOffset, nCurrentTabIndex);
                     }


More information about the Libreoffice-commits mailing list