[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source

[Libreoffice Gerrit user]

 sc/source/core/data/column.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 439407a36e4085c17c65c620a1bb2ca95f4564b0
Author:     Eike Rathke <erack at redhat.com>
AuthorDate: Wed Feb 6 14:53:26 2019 +0100
Commit:     Kohei Yoshida <libreoffice at kohei.us>
CommitDate: Sat Feb 9 01:10:48 2019 +0100

    Resolves: tdf#121002 UpdateRefOnNonCopy::mbUpdated=true if references change
    
    ... somewhere in a previous shared formula group, so for the new groups
    after split the column is added to sc::RefUpdateContext::maRegroupCols
    in ScColumn::UpdateReference() to setup new listeners later, and true
    returned there, which also results in ScTable::SetStreamValid(false) at
    the end, which in this constellation wasn't the case.
    
    It may have been a reason that some documents have individual
    unrecalculated results stored (i.e. values moved within ranges that a
    shared formula group pointed to) that can be corrected by recalculating
    after load.
    
    Said to be a regression from
    
        commit 2f6a06856ad8df0c11a112d1e457b408e9a7af1d
        CommitDate: Fri Jun 5 16:22:38 2015 +0200
    
            tdf#90694 reset group area listeners when splitting group
    
    but that only uncovered this misbehaviour.
    
    Change-Id: I6b04b71898c3f1774452dd19790c208f3167d8eb
    Reviewed-on: https://gerrit.libreoffice.org/67461
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Jenkins
    (cherry picked from commit cdfa8b27f28328612b6734533981c1b363ced0a0)
    Reviewed-on: https://gerrit.libreoffice.org/67466
    Reviewed-by: Kohei Yoshida <libreoffice at kohei.us>

diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index d8f164e0c916..6e34a6757fe5 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -2264,6 +2264,8 @@ class UpdateRefOnNonCopy
                 p->SetDirty();
             }
 
+            mbUpdated = true;
+
             // Move from clipboard is Cut&Paste, then do not copy the original
             // positions' formula cells to the Undo document.
             if (!mbClipboardSource || !bCellMoved)