[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed Jan 2 08:07:34 UTC 2019


 wsd/DocumentBroker.cpp |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3d38a71d77f4a089b1ffdae251a9e595f0afe29d
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Wed Jan 2 09:07:06 2019 +0100
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Wed Jan 2 09:07:06 2019 +0100

    Minor cleanups in DocumentBroker
    
    documentLastModifiedTime was an unnecessary value parameter, filename
    was copy-initialized without a reason.
    
    Change-Id: I5e5a2fe9d9fcde61db539e30689492b8c191b598

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 4199ece0c..c21177af1 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -61,7 +61,7 @@ namespace
 
 void sendLastModificationTime(const std::shared_ptr<Session>& session,
                               DocumentBroker* documentBroker,
-                              Poco::Timestamp documentLastModifiedTime)
+                              const Poco::Timestamp& documentLastModifiedTime)
 {
     if (!session)
         return;
@@ -878,7 +878,7 @@ bool DocumentBroker::saveToStorageInternal(const std::string& sessionId,
             // normalize the url (mainly to " " -> "%20")
             const std::string url = Poco::URI(storageSaveResult.getSaveAsUrl()).toString();
 
-            const std::string filename = storageSaveResult.getSaveAsName();
+            const std::string& filename = storageSaveResult.getSaveAsName();
 
             // encode the name
             std::string encodedName;


More information about the Libreoffice-commits mailing list