[Libreoffice-commits] core.git: include/salhelper salhelper/IwyuFilter_salhelper.yaml salhelper/qa salhelper/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed Jan 9 07:42:14 UTC 2019


 include/salhelper/condition.hxx     |    3 ---
 salhelper/IwyuFilter_salhelper.yaml |    2 ++
 salhelper/qa/test_api.cxx           |    8 --------
 salhelper/source/dynload.cxx        |    1 -
 salhelper/source/timer.cxx          |    1 -
 5 files changed, 2 insertions(+), 13 deletions(-)

New commits:
commit 54515a6a01a372729bf8a7f9e992c51f214ec9a6
Author:     Gabor Kelemen <kelemeng at ubuntu.com>
AuthorDate: Wed Dec 26 16:58:46 2018 +0100
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Wed Jan 9 08:41:50 2019 +0100

    tdf#42949 Fix IWYU warnings in salhelper/
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here
    and only for files that are actually compiling
    
    Change-Id: I70357eade9552984fdb3b7590f1e8237a02a7d1d
    Reviewed-on: https://gerrit.libreoffice.org/65650
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

diff --git a/include/salhelper/condition.hxx b/include/salhelper/condition.hxx
index 06cadec852f3..0f936d4e5b40 100644
--- a/include/salhelper/condition.hxx
+++ b/include/salhelper/condition.hxx
@@ -29,9 +29,6 @@ namespace osl { class Mutex; }
 
 namespace salhelper
 {
-    class ConditionModifier;
-    class ConditionWaiter;
-
 
     class SALHELPER_DLLPUBLIC Condition
     {
diff --git a/salhelper/IwyuFilter_salhelper.yaml b/salhelper/IwyuFilter_salhelper.yaml
new file mode 100644
index 000000000000..f017243be88c
--- /dev/null
+++ b/salhelper/IwyuFilter_salhelper.yaml
@@ -0,0 +1,2 @@
+---
+assumeFilename: salhelper/source/dynload.cxx
diff --git a/salhelper/qa/test_api.cxx b/salhelper/qa/test_api.cxx
index 2e276860037c..dd45f4c730f2 100644
--- a/salhelper/qa/test_api.cxx
+++ b/salhelper/qa/test_api.cxx
@@ -30,14 +30,6 @@
 #include <cppunit/plugin/TestPlugIn.h>
 #include <memory>
 
-namespace salhelper {
-    class Condition;
-    class ConditionModifier;
-    class ConditionWaiter;
-    class ORealDynamicLoader;
-    class SimpleReferenceObject;
-}
-
 namespace {
 
 std::type_info const & getConditionTypeInfo()
diff --git a/salhelper/source/dynload.cxx b/salhelper/source/dynload.cxx
index 63e3201f3ae7..d3b8e70fb292 100644
--- a/salhelper/source/dynload.cxx
+++ b/salhelper/source/dynload.cxx
@@ -18,7 +18,6 @@
  */
 
 #include <salhelper/dynload.hxx>
-#include <rtl/ustrbuf.hxx>
 
 namespace salhelper
 {
diff --git a/salhelper/source/timer.cxx b/salhelper/source/timer.cxx
index b4e2dba961ee..8101b23875fb 100644
--- a/salhelper/source/timer.cxx
+++ b/salhelper/source/timer.cxx
@@ -17,7 +17,6 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 #include <salhelper/timer.hxx>
-#include <salhelper/simplereferenceobject.hxx>
 
 #include <osl/thread.hxx>
 #include <osl/conditn.hxx>


More information about the Libreoffice-commits mailing list