[Libreoffice-commits] core.git: vcl/unx

[Libreoffice Gerrit user]

 vcl/unx/gtk/a11y/atklistener.cxx |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 8254b4abdc32c5d4b93cc7dbef4a479b3efc3460
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Jan 9 15:41:56 2019 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Jan 9 22:07:44 2019 +0100

    Resolves: tdf#122353 silence useless selection-changed event attempts
    
    Change-Id: Ie84fb12e6561d93832159779d233102a34b1c78c
    Reviewed-on: https://gerrit.libreoffice.org/66042
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk/a11y/atklistener.cxx b/vcl/unx/gtk/a11y/atklistener.cxx
index bba1a3a09d53..61df38a27beb 100644
--- a/vcl/unx/gtk/a11y/atklistener.cxx
+++ b/vcl/unx/gtk/a11y/atklistener.cxx
@@ -701,7 +701,13 @@ void AtkListener::notifyEvent( const accessibility::AccessibleEventObject& aEven
         case accessibility::AccessibleEventId::SELECTION_CHANGED_ADD:
         case accessibility::AccessibleEventId::SELECTION_CHANGED_REMOVE:
         case accessibility::AccessibleEventId::SELECTION_CHANGED_WITHIN:
-            g_signal_emit_by_name( G_OBJECT( atk_obj ), "selection_changed");
+            if (ATK_IS_SELECTION(atk_obj))
+                g_signal_emit_by_name(G_OBJECT(atk_obj), "selection_changed");
+            else
+            {
+                // e.g. tdf#122353, when such dialogs become native the problem will go away anyway
+                SAL_INFO("vcl.gtk", "selection change from obj which doesn't support XAccessibleSelection");
+            }
             break;
 
         case accessibility::AccessibleEventId::HYPERTEXT_CHANGED: