[Libreoffice-commits] core.git: sc/source

[Libreoffice Gerrit user]

 sc/source/filter/oox/sheetdatabuffer.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit ab9aec1c97a69fb0d8df6f04eefdd02291c974cf
Author:     Arkadiy Illarionov <qarkai at gmail.com>
AuthorDate: Sat Jan 19 21:29:03 2019 +0300
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Sun Jan 20 11:58:11 2019 +0100

    Check id in outer loop
    
    Change-Id: I24ecf429d26c19823cd76128d2b5e0ec3bdf82c7
    Reviewed-on: https://gerrit.libreoffice.org/66639
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sc/source/filter/oox/sheetdatabuffer.cxx b/sc/source/filter/oox/sheetdatabuffer.cxx
index 1051399d91d6..9a0240ec631d 100644
--- a/sc/source/filter/oox/sheetdatabuffer.cxx
+++ b/sc/source/filter/oox/sheetdatabuffer.cxx
@@ -428,12 +428,12 @@ void SheetDataBuffer::finalizeImport()
 
     for ( std::map< sal_Int32, std::vector< ValueRange > >::iterator it = maXfIdRowRangeList.begin(), it_end =  maXfIdRowRangeList.end(); it != it_end; ++it )
     {
+        if ( it->first == -1 ) // it's a dud skip it
+            continue;
         AddressConverter& rAddrConv = getAddressConverter();
         // get all row ranges for id
         for ( std::vector< ValueRange >::iterator rangeIter = it->second.begin(), rangeIter_end = it->second.end(); rangeIter != rangeIter_end; ++rangeIter )
         {
-            if ( it->first == -1 ) // it's a dud skip it
-                continue;
             ScRange aRange( 0, rangeIter->mnFirst, getSheetIndex(),
                             rAddrConv.getMaxApiAddress().Col(), rangeIter->mnLast, getSheetIndex() );