[Libreoffice-commits] core.git: sd/inc sd/qa sd/source starmath/inc starmath/source store/source svtools/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Jan 24 10:02:00 UTC 2019


 sd/inc/customshowlist.hxx                       |    2 +-
 sd/qa/unit/export-tests-ooxml2.cxx              |    4 ++--
 sd/source/ui/animations/CustomAnimationPane.cxx |    2 +-
 sd/source/ui/dlg/sdtreelb.cxx                   |    2 +-
 sd/source/ui/inc/sdtreelb.hxx                   |    2 +-
 starmath/inc/dialog.hxx                         |    2 +-
 starmath/source/dialog.cxx                      |    2 +-
 store/source/storbase.hxx                       |    2 +-
 svtools/source/control/ruler.cxx                |    2 +-
 9 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 4085f6ca9b345c362bb286e6fb1b17b2fcf2bc4c
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Jan 24 09:29:27 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Thu Jan 24 11:01:34 2019 +0100

    loplugin:constparams in sd..svtools
    
    Change-Id: I50b864ffc4ed13ba801af46815988bf568b83d2e
    Reviewed-on: https://gerrit.libreoffice.org/66832
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sd/inc/customshowlist.hxx b/sd/inc/customshowlist.hxx
index 666e43614ce2..c612ce4bf93e 100644
--- a/sd/inc/customshowlist.hxx
+++ b/sd/inc/customshowlist.hxx
@@ -77,7 +77,7 @@ public:
     {
         return mShows.empty() ? nullptr : mShows[mnCurPos].get();
     }
-    void erase(SdCustomShow* p)
+    void erase(const SdCustomShow* p)
     {
         auto it = std::find_if(mShows.begin(), mShows.end(),
                 [&] (std::unique_ptr<SdCustomShow> const &i) { return i.get() == p; });
diff --git a/sd/qa/unit/export-tests-ooxml2.cxx b/sd/qa/unit/export-tests-ooxml2.cxx
index 503b913b1ce0..0d63f6b0f508 100644
--- a/sd/qa/unit/export-tests-ooxml2.cxx
+++ b/sd/qa/unit/export-tests-ooxml2.cxx
@@ -1878,7 +1878,7 @@ void SdOOXMLExportTest2::testTdf118836()
     xDocShRef->DoClose();
 }
 
-static double getAdjustmentValue( uno::Reference<beans::XPropertySet>& xSet )
+static double getAdjustmentValue( const uno::Reference<beans::XPropertySet>& xSet )
 {
     auto aGeomPropSeq = xSet->getPropertyValue( "CustomShapeGeometry" )
                             .get<uno::Sequence<beans::PropertyValue>>();
@@ -1903,7 +1903,7 @@ static double getAdjustmentValue( uno::Reference<beans::XPropertySet>& xSet )
     return -1.0;
 }
 
-static bool getScaleXValue(uno::Reference<beans::XPropertySet>& xSet)
+static bool getScaleXValue(const uno::Reference<beans::XPropertySet>& xSet)
 {
     bool bScaleX = false;
 
diff --git a/sd/source/ui/animations/CustomAnimationPane.cxx b/sd/source/ui/animations/CustomAnimationPane.cxx
index 60f052445929..384ea90559e2 100644
--- a/sd/source/ui/animations/CustomAnimationPane.cxx
+++ b/sd/source/ui/animations/CustomAnimationPane.cxx
@@ -907,7 +907,7 @@ void CustomAnimationPane::UpdateLook()
     }
 }
 
-static void addValue( std::unique_ptr<STLPropertySet>& pSet, sal_Int32 nHandle, const Any& rValue )
+static void addValue( const std::unique_ptr<STLPropertySet>& pSet, sal_Int32 nHandle, const Any& rValue )
 {
     switch( pSet->getPropertyState( nHandle ) )
     {
diff --git a/sd/source/ui/dlg/sdtreelb.cxx b/sd/source/ui/dlg/sdtreelb.cxx
index 1d7805360d79..c88a401af4ed 100644
--- a/sd/source/ui/dlg/sdtreelb.cxx
+++ b/sd/source/ui/dlg/sdtreelb.cxx
@@ -227,7 +227,7 @@ void SdPageObjsTLB::SetSdNavigator(SdNavigatorWin* pNavigator)
     mpNavigator = pNavigator;
 }
 
-void SdPageObjsTLB::SetViewFrame( SfxViewFrame* pViewFrame )
+void SdPageObjsTLB::SetViewFrame( const SfxViewFrame* pViewFrame )
 {
     sd::ViewShellBase* pBase = sd::ViewShellBase::GetViewShellBase(pViewFrame);
     const css::uno::Reference< css::frame::XFrame > xFrame = pBase->GetMainViewShell()->GetViewFrame()->GetFrame().GetFrameInterface();
diff --git a/sd/source/ui/inc/sdtreelb.hxx b/sd/source/ui/inc/sdtreelb.hxx
index cea96d1a839d..d32d23666162 100644
--- a/sd/source/ui/inc/sdtreelb.hxx
+++ b/sd/source/ui/inc/sdtreelb.hxx
@@ -189,7 +189,7 @@ public:
     virtual void            KeyInput( const KeyEvent& rKEvt ) override;
     void MouseButtonDown(const MouseEvent& rMEvt) override;
 
-    void                    SetViewFrame( SfxViewFrame* pViewFrame );
+    void                    SetViewFrame( const SfxViewFrame* pViewFrame );
 
     void                    Fill( const SdDrawDocument*, bool bAllPages, const OUString& rDocName );
     void                    Fill( const SdDrawDocument*, SfxMedium* pSfxMedium, const OUString& rDocName );
diff --git a/starmath/inc/dialog.hxx b/starmath/inc/dialog.hxx
index 63426947f059..6c1ccfb0cb80 100644
--- a/starmath/inc/dialog.hxx
+++ b/starmath/inc/dialog.hxx
@@ -272,7 +272,7 @@ public:
                                        pDrawingArea->get_text_height() * 9);
     }
 
-    void calccols(vcl::RenderContext& rRenderContext);
+    void calccols(const vcl::RenderContext& rRenderContext);
     void    SelectSymbol(sal_uInt16 nSymbol);
     sal_uInt16  GetSelectSymbol() const { return nSelectSymbol; }
     void SetSymbolSet(const SymbolPtrVec_t& rSymbolSet);
diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index 528983c89e43..973bfc716e28 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -1065,7 +1065,7 @@ bool SmShowSymbolSet::KeyInput(const KeyEvent& rKEvt)
     return true;
 }
 
-void SmShowSymbolSet::calccols(vcl::RenderContext& rRenderContext)
+void SmShowSymbolSet::calccols(const vcl::RenderContext& rRenderContext)
 {
     // Height of 16pt in pixels (matching 'aOutputSize')
     nLen = rRenderContext.LogicToPixel(Size(0, 16), MapMode(MapUnit::MapPoint)).Height();
diff --git a/store/source/storbase.hxx b/store/source/storbase.hxx
index 9a630348e58f..5ced6d255c4e 100644
--- a/store/source/storbase.hxx
+++ b/store/source/storbase.hxx
@@ -483,7 +483,7 @@ public:
         return (*pImpl);
     }
 
-    static storeError guard (std::shared_ptr<PageData> & rxPage, sal_uInt32 nAddr)
+    static storeError guard (std::shared_ptr<PageData> const & rxPage, sal_uInt32 nAddr)
     {
         PageData * pHead = rxPage.get();
         if (!pHead)
diff --git a/svtools/source/control/ruler.cxx b/svtools/source/control/ruler.cxx
index 3d2047a60de2..91f1e2536017 100644
--- a/svtools/source/control/ruler.cxx
+++ b/svtools/source/control/ruler.cxx
@@ -69,7 +69,7 @@ namespace
  * Pre-calculates glyph items for rText on rRenderContext. Subsequent calls
  * avoid the calculation and just return a pointer to rTextGlyphs.
  */
-SalLayoutGlyphs* lcl_GetRulerTextGlyphs(vcl::RenderContext& rRenderContext, const OUString& rText,
+SalLayoutGlyphs* lcl_GetRulerTextGlyphs(const vcl::RenderContext& rRenderContext, const OUString& rText,
                                         SalLayoutGlyphs& rTextGlyphs)
 {
     if (rTextGlyphs.IsValid())


More information about the Libreoffice-commits mailing list