[Libreoffice-commits] core.git: connectivity/source

[Libreoffice Gerrit user]

 connectivity/source/drivers/firebird/Connection.cxx |    2 +-
 connectivity/source/drivers/firebird/Driver.cxx     |    3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

New commits:
commit e9e1813a6ebe6e3015e04347b15a18aebc4e0fa7
Author:     Lionel Elie Mamane <lionel at mamane.lu>
AuthorDate: Mon Jan 28 15:44:36 2019 +0100
Commit:     Lionel Elie Mamane <lionel at mamane.lu>
CommitDate: Tue Jan 29 08:42:19 2019 +0100

    tdf#106463 set new firebird connections as autocommit by default
    
    as per SDBC specifications
    
    Change-Id: I132a8e565468bcacf0fa5ee0dfb62bf0dd717e24
    Reviewed-on: https://gerrit.libreoffice.org/67015
    Tested-by: Jenkins
    Reviewed-by: Tamás Bunth <btomi96 at gmail.com>
    Reviewed-by: Lionel Elie Mamane <lionel at mamane.lu>

diff --git a/connectivity/source/drivers/firebird/Connection.cxx b/connectivity/source/drivers/firebird/Connection.cxx
index b7f1276a8d4f..ba2fba974d78 100644
--- a/connectivity/source/drivers/firebird/Connection.cxx
+++ b/connectivity/source/drivers/firebird/Connection.cxx
@@ -87,7 +87,7 @@ Connection::Connection()
     , m_sFirebirdURL()
     , m_bIsEmbedded(false)
     , m_bIsFile(false)
-    , m_bIsAutoCommit(false)
+    , m_bIsAutoCommit(true)
     , m_bIsReadOnly(false)
     , m_aTransactionIsolation(TransactionIsolation::REPEATABLE_READ)
 #if SAL_TYPES_SIZEOFPOINTER == 8
diff --git a/connectivity/source/drivers/firebird/Driver.cxx b/connectivity/source/drivers/firebird/Driver.cxx
index 199529016995..8e81ae9ae9b8 100644
--- a/connectivity/source/drivers/firebird/Driver.cxx
+++ b/connectivity/source/drivers/firebird/Driver.cxx
@@ -181,9 +181,6 @@ Reference< XConnection > SAL_CALL FirebirdDriver::connect(
     Reference< XConnection > xCon = pCon;
     pCon->construct(url, info);
 
-    if (url == "sdbc:embedded:firebird")
-        pCon->setAutoCommit(true);
-
     m_xConnections.push_back(WeakReferenceHelper(*pCon));
 
     return xCon;