[Libreoffice-commits] core.git: scripting/java

Julien Nabet (via logerrit) logerrit at kemper.freedesktop.org
Wed Jul 3 20:55:22 UTC 2019


 scripting/java/com/sun/star/script/framework/container/ParcelDescriptor.java |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

New commits:
commit 04fbd174cb787ea15fb74abeca37589ab74df6ab
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Wed Jul 3 21:46:42 2019 +0200
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Wed Jul 3 22:54:07 2019 +0200

    cid#1448470: perf inefficient map iterator
    
    Change-Id: If7dd6455ca02d6c78ac997bd9c2924863db1d906
    Reviewed-on: https://gerrit.libreoffice.org/75059
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/scripting/java/com/sun/star/script/framework/container/ParcelDescriptor.java b/scripting/java/com/sun/star/script/framework/container/ParcelDescriptor.java
index a8b12e071284..eeb8f9ef2cfc 100644
--- a/scripting/java/com/sun/star/script/framework/container/ParcelDescriptor.java
+++ b/scripting/java/com/sun/star/script/framework/container/ParcelDescriptor.java
@@ -338,13 +338,10 @@ public class ParcelDescriptor {
             String key;
             item = document.createElement("languagedepprops");
 
-            Iterator<String> iter = languagedepprops.keySet().iterator();
-
-            while (iter.hasNext()) {
+            for (Map.Entry<String, String> entry : languagedepprops.entrySet()) {
                 tempitem = document.createElement("prop");
-                key = iter.next();
-                tempitem.setAttribute("name", key);
-                tempitem.setAttribute("value", languagedepprops.get(key));
+                tempitem.setAttribute("name", entry.getKey());
+                tempitem.setAttribute("value", entry.getValue());
                 item.appendChild(tempitem);
             }
 


More information about the Libreoffice-commits mailing list