[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - avmedia/source

[Julien Nabet (via logerrit)]

 avmedia/source/gstreamer/gstplayer.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 280016e6c7df52de040e3b086747237bb9d84e2c
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Thu Jul 4 18:09:26 2019 +0200
Commit:     Michael Stahl <Michael.Stahl at cib.de>
CommitDate: Fri Jul 5 10:56:51 2019 +0200

    cid#1448380: Resource leak (avmedia/gstplayer)
    
    Change-Id: Ieaf5f68f17558f27e187241869c8fe01f8e29ba2
    Reviewed-on: https://gerrit.libreoffice.org/75100
    Tested-by: Jenkins
    Reviewed-by: Michael Stahl <Michael.Stahl at cib.de>

diff --git a/avmedia/source/gstreamer/gstplayer.cxx b/avmedia/source/gstreamer/gstplayer.cxx
index 0236f7895b8c..0871ecd2ea53 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -939,10 +939,9 @@ uno::Reference< ::media::XPlayerWindow > SAL_CALL Player::createPlayerWindow( co
 
     if( aSize.Width > 0 && aSize.Height > 0 )
     {
-        ::avmedia::gstreamer::Window* pWindow = new ::avmedia::gstreamer::Window;
         if (rArguments.getLength() <= 2)
         {
-            xRet = pWindow;
+            xRet = new ::avmedia::gstreamer::Window;
             return xRet;
         }
 
@@ -986,7 +985,7 @@ uno::Reference< ::media::XPlayerWindow > SAL_CALL Player::createPlayerWindow( co
                 return nullptr;
         }
 
-        xRet = pWindow;
+        xRet = new ::avmedia::gstreamer::Window;
 
         g_object_set(G_OBJECT(mpPlaybin), "video-sink", pVideosink, nullptr);
         g_object_set(G_OBJECT(mpPlaybin), "force-aspect-ratio", FALSE, nullptr);