[Libreoffice-commits] core.git: sc/qa

[Jan-Marek Glogowski (via logerrit)]

 sc/qa/unit/subsequent_export-test.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit dfdd2b0126a677960946c5ff2b905e95b978b2d5
Author:     Jan-Marek Glogowski <glogow at fbihome.de>
AuthorDate: Sun Jul 7 02:34:05 2019 +0200
Commit:     Thorsten Behrens <Thorsten.Behrens at CIB.de>
CommitDate: Sun Jul 7 10:02:54 2019 +0200

    tdf#126255 disable broken relative link unit test
    
    Relative links are currently broken and this was hidden by this
    unit test. Funnily asserting for aURL.startsWith("..") happens to
    work for most tested build targets, but the link is generally
    wrong, even if it starts with "..".
    
    I don't know either how to retrieve the relative link from the XML
    nor how to generate the correct link in Calc, so this unit test
    can test, if the linked document exists and work correctly.
    
    So - hopefully as a temporarly measure - this disables the
    comparing assertion, until the bug and test are fixed.
    
    Change-Id: I165ac3ce763133fcef6cea5a8dd221b0076f1ee4
    Reviewed-on: https://gerrit.libreoffice.org/75172
    Tested-by: Jenkins
    Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>

diff --git a/sc/qa/unit/subsequent_export-test.cxx b/sc/qa/unit/subsequent_export-test.cxx
index 473be4c8593b..b2bc00573688 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -3080,10 +3080,12 @@ void ScExportTest::testRelativePathsODS()
 
     xmlDocPtr pDoc = XPathHelper::parseExport2(*this, *xDocSh, m_xSFactory, "content.xml", FORMAT_ODS);
     CPPUNIT_ASSERT(pDoc);
+    // FIXME: make sure that the URL is relative and actually points to the existing document
+#if 0
     OUString aURL = getXPath(pDoc,
             "/office:document-content/office:body/office:spreadsheet/table:table/table:table-row[2]/table:table-cell[2]/text:p/text:a", "href");
-    // make sure that the URL is relative
     CPPUNIT_ASSERT(aURL.startsWith(".."));
+#endif
 }
 
 namespace {