[Libreoffice-commits] core.git: vcl/source

[Samuel Mehrbrodt (via logerrit)]

 vcl/source/window/seleng.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c554afd565ea515decd483a9068f6590c5316dce
Author:     Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
AuthorDate: Fri Jul 5 12:40:16 2019 +0200
Commit:     Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
CommitDate: Mon Jul 8 10:01:18 2019 +0200

    Right clicking in text should move the cursor
    
    Currently the cursor stays at the old position when you right click
    in a different position in the text.
    This causes some issues, e.g. when you right click on a hyperlink in
    draw, you don't get the context menu for the link if the cursor is not
    on the link (see tdf#98575 for related bug).
    
    So generally, when right clicking on a piece of text, move the cursor
    to where the click happened.
    
    The new behavior is now matching the behavior of Word, PowerPoint, etc.
    
    Change-Id: I5e0ac37b7ac6c859d3056c5b8ed453f97c747360
    Reviewed-on: https://gerrit.libreoffice.org/75127
    Tested-by: Jenkins
    Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>

diff --git a/vcl/source/window/seleng.cxx b/vcl/source/window/seleng.cxx
index 84481d6e1933..cb3b19056bcd 100644
--- a/vcl/source/window/seleng.cxx
+++ b/vcl/source/window/seleng.cxx
@@ -115,7 +115,7 @@ void SelectionEngine::CursorPosChanging( bool bShift, bool bMod1 )
 bool SelectionEngine::SelMouseButtonDown( const MouseEvent& rMEvt )
 {
     nFlags &= ~SelectionEngineFlags::CMDEVT;
-    if ( !pFunctionSet || rMEvt.GetClicks() > 1 || rMEvt.IsRight() )
+    if ( !pFunctionSet || rMEvt.GetClicks() > 1 )
         return false;
 
     sal_uInt16 nModifier = rMEvt.GetModifier() | nLockedMods;