[Libreoffice-commits] core.git: sc/qa

Eike Rathke (via logerrit) logerrit at kemper.freedesktop.org
Mon Jul 8 15:21:27 UTC 2019


 sc/qa/unit/subsequent_export-test.cxx |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 1458d43690684c5ce6ed4409bef34a23cfbab7f2
Author:     Eike Rathke <erack at redhat.com>
AuthorDate: Mon Jul 8 13:49:01 2019 +0200
Commit:     Eike Rathke <erack at redhat.com>
CommitDate: Mon Jul 8 17:20:22 2019 +0200

    Revert "tdf#126255 disable broken relative link unit test"
    
    This reverts commit dfdd2b0126a677960946c5ff2b905e95b978b2d5.
    
    Wrong assumptions about xlink:href, see
    https://bugs.documentfoundation.org/show_bug.cgi?id=126255#c5
    
    Change-Id: Ib9522f702205befe71a1992d4811c1064ac6746f
    Reviewed-on: https://gerrit.libreoffice.org/75220
    Tested-by: Jenkins
    Reviewed-by: Eike Rathke <erack at redhat.com>

diff --git a/sc/qa/unit/subsequent_export-test.cxx b/sc/qa/unit/subsequent_export-test.cxx
index b2bc00573688..473be4c8593b 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -3080,12 +3080,10 @@ void ScExportTest::testRelativePathsODS()
 
     xmlDocPtr pDoc = XPathHelper::parseExport2(*this, *xDocSh, m_xSFactory, "content.xml", FORMAT_ODS);
     CPPUNIT_ASSERT(pDoc);
-    // FIXME: make sure that the URL is relative and actually points to the existing document
-#if 0
     OUString aURL = getXPath(pDoc,
             "/office:document-content/office:body/office:spreadsheet/table:table/table:table-row[2]/table:table-cell[2]/text:p/text:a", "href");
+    // make sure that the URL is relative
     CPPUNIT_ASSERT(aURL.startsWith(".."));
-#endif
 }
 
 namespace {


More information about the Libreoffice-commits mailing list