[Libreoffice-commits] core.git: oox/source

[Mike Kaganski (via logerrit)]

 oox/source/drawingml/shape.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d4b687a503159c8c1385db9d7fbff5c92ace6900
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Tue Jul 9 13:33:13 2019 +0200
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Tue Jul 9 15:25:57 2019 +0200

    mxShape.is() is always true here
    
    Change-Id: I30b11b0291ef4cbf793352b0b23b04857892a714
    Reviewed-on: https://gerrit.libreoffice.org/75297
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index 88ed816c21c0..7be3aa837657 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -887,7 +887,7 @@ Reference< XShape > const & Shape::createAndInsert(
         mxShape.set( xServiceFact->createInstance( aServiceName ), UNO_QUERY_THROW );
 
     Reference< XPropertySet > xSet( mxShape, UNO_QUERY );
-    if( mxShape.is() && xSet.is() )
+    if (xSet.is())
     {
         if( !msName.isEmpty() )
         {