[Libreoffice-commits] core.git: sd/inc sd/IwyuFilter_sd.yaml sd/source

Gabor Kelemen (via logerrit) logerrit at kemper.freedesktop.org
Wed Jul 10 07:51:57 UTC 2019 

 sd/IwyuFilter_sd.yaml                               |    6 ++++++
 sd/inc/notifydocumentevent.hxx                      |    2 ++
 sd/inc/randomnode.hxx                               |    5 +++++
 sd/inc/sdpptwrp.hxx                                 |    2 ++
 sd/inc/shapelist.hxx                                |    1 +
 sd/inc/stlpool.hxx                                  |    1 +
 sd/source/filter/eppt/pptx-animations.hxx           |    7 +++++++
 sd/source/filter/xml/sdtransform.hxx                |    2 ++
 sd/source/ui/dlg/BulletAndPositionDlg.cxx           |    1 +
 sd/source/ui/dlg/PhotoAlbumDialog.hxx               |    2 ++
 sd/source/ui/inc/AccessibleOutlineEditSource.hxx    |    1 +
 sd/source/ui/inc/BulletAndPositionDlg.hxx           |    3 ---
 sd/source/ui/inc/assclass.hxx                       |    1 +
 sd/source/ui/inc/createcustomanimationpanel.hxx     |    5 +++++
 sd/source/ui/inc/createslidetransitionpanel.hxx     |    5 +++++
 sd/source/ui/inc/dlgpage.hxx                        |    1 +
 sd/source/ui/inc/docprev.hxx                        |    2 ++
 sd/source/ui/inc/filedlg.hxx                        |    1 +
 sd/source/ui/inc/registerinterfaces.hxx             |    1 +
 sd/source/ui/inc/sdpopup.hxx                        |    1 +
 sd/source/ui/inc/tablefunction.hxx                  |    3 +++
 sd/source/ui/inc/tpaction.hxx                       |    1 +
 sd/source/ui/inc/unchss.hxx                         |    2 ++
 sd/source/ui/inc/undoback.hxx                       |    2 ++
 sd/source/ui/inc/unokywds.hxx                       |    2 --
 sd/source/ui/remotecontrol/ZeroconfService.hxx      |    2 --
 sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx |    2 ++
 sd/source/ui/sidebar/MasterPagesSelector.hxx        |    2 +-
 sd/source/ui/slideshow/slideshowviewimpl.hxx        |    1 -
 sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx    |    1 +
 sd/source/ui/unoidl/unopool.hxx                     |    3 +++
 31 files changed, 62 insertions(+), 9 deletions(-)

New commits:
commit e77999fda551867e4fc199a489cf898821ef6d09
Author:     Gabor Kelemen <kelemen.gabor2 at nisz.hu>
AuthorDate: Sat Jun 29 22:13:45 2019 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Wed Jul 10 09:51:15 2019 +0200

    tdf#42949 Fix IWYU warnings in sd/*/hxx
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here.
    
    New IWYU and recent developments in f-u-i helped to identify
    some non self contained files, those were fixed too.
    
    Change-Id: I4b1b4fe59c572cdd969d26aac13a276d5aa6844c
    Reviewed-on: https://gerrit.libreoffice.org/74981
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

diff --git a/sd/IwyuFilter_sd.yaml b/sd/IwyuFilter_sd.yaml
index 930f081dd117..13a431777e23 100644
--- a/sd/IwyuFilter_sd.yaml
+++ b/sd/IwyuFilter_sd.yaml
@@ -279,6 +279,9 @@ blacklist:
     sd/source/ui/sidebar/PanelFactory.hxx:
     # base class has to be a complete type
     - com/sun/star/ui/XUIElementFactory.hpp
+    sd/source/ui/sidebar/PageMarginUtils.hxx:
+    # Needed for std::abs
+    - cmath
     sd/source/ui/slideshow/slideshowimpl.hxx:
     # base class has to be a complete type
     - com/sun/star/presentation/XShapeEventListener.hpp
@@ -411,6 +414,9 @@ blacklist:
     sd/source/filter/eppt/epptso.cxx:
     # Needed for direct member access
     - com/sun/star/table/XTable.hpp
+    sd/source/filter/eppt/pptx-animations.hxx:
+    # Needed for typedef
+    - sax/fshelper.hxx
     sd/source/filter/eppt/pptx-epptooxml.cxx:
     # Needed for direct member access
     - com/sun/star/task/XStatusIndicator.hpp
diff --git a/sd/inc/notifydocumentevent.hxx b/sd/inc/notifydocumentevent.hxx
index 960999774c02..16c74a318522 100644
--- a/sd/inc/notifydocumentevent.hxx
+++ b/sd/inc/notifydocumentevent.hxx
@@ -21,6 +21,8 @@
 #define INCLUDED_SD_INC_NOTIFYDOCUMENTEVENT_HXX
 
 #include <sal/config.h>
+#include <rtl/ustring.hxx>
+#include <com/sun/star/uno/Reference.hxx>
 
 class SdDrawDocument;
 
diff --git a/sd/inc/randomnode.hxx b/sd/inc/randomnode.hxx
index 83cb52b44c38..2a30b448541e 100644
--- a/sd/inc/randomnode.hxx
+++ b/sd/inc/randomnode.hxx
@@ -22,6 +22,11 @@
 
 #include <sal/config.h>
 
+#include <com/sun/star/uno/Reference.hxx>
+#include <com/sun/star/uno/XInterface.hpp>
+
+#include "sddllapi.h"
+
 namespace sd {
 
 SD_DLLPUBLIC css::uno::Reference<css::uno::XInterface>
diff --git a/sd/inc/sdpptwrp.hxx b/sd/inc/sdpptwrp.hxx
index 85ad2ffa5ad2..6414226d4596 100644
--- a/sd/inc/sdpptwrp.hxx
+++ b/sd/inc/sdpptwrp.hxx
@@ -22,6 +22,8 @@
 
 #include "sdfilter.hxx"
 
+#include <tools/stream.hxx>
+
 // SdPPTFilter
 class SdPPTFilter : public SdFilter
 {
diff --git a/sd/inc/shapelist.hxx b/sd/inc/shapelist.hxx
index a129b9fceca5..beef8211c9bb 100644
--- a/sd/inc/shapelist.hxx
+++ b/sd/inc/shapelist.hxx
@@ -20,6 +20,7 @@
 #ifndef INCLUDED_SD_INC_SHAPELIST_HXX
 #define INCLUDED_SD_INC_SHAPELIST_HXX
 
+#include <sal/types.h>
 #include <svx/sdrobjectuser.hxx>
 
 #include <list>
diff --git a/sd/inc/stlpool.hxx b/sd/inc/stlpool.hxx
index d1fd4505fc80..3f60309813a2 100644
--- a/sd/inc/stlpool.hxx
+++ b/sd/inc/stlpool.hxx
@@ -25,6 +25,7 @@
 #include <com/sun/star/lang/XComponent.hpp>
 
 #include <cppuhelper/implbase.hxx>
+#include <vcl/font.hxx>
 #include <map>
 #include <vector>
 
diff --git a/sd/source/filter/eppt/pptx-animations.hxx b/sd/source/filter/eppt/pptx-animations.hxx
index 738100befee0..67aeb4fda7e1 100644
--- a/sd/source/filter/eppt/pptx-animations.hxx
+++ b/sd/source/filter/eppt/pptx-animations.hxx
@@ -9,6 +9,13 @@
 #ifndef INCLUDED_SD_SOURCE_FILTER_EPPT_EPPTANIMATIONS_HXX
 #define INCLUDED_SD_SOURCE_FILTER_EPPT_EPPTANIMATIONS_HXX
 
+#include <sax/fshelper.hxx>
+
+#include <com/sun/star/drawing/XDrawPage.hpp>
+#include <com/sun/star/uno/Reference.hxx>
+
+#include "epptooxml.hxx"
+
 namespace oox
 {
 namespace core
diff --git a/sd/source/filter/xml/sdtransform.hxx b/sd/source/filter/xml/sdtransform.hxx
index 13b75c632042..381020461418 100644
--- a/sd/source/filter/xml/sdtransform.hxx
+++ b/sd/source/filter/xml/sdtransform.hxx
@@ -22,6 +22,8 @@
 
 #include <sal/config.h>
 
+#include <drawdoc.hxx>
+
 void TransformOOo2xDocument( SdDrawDocument* pDocument );
 
 #endif
diff --git a/sd/source/ui/dlg/BulletAndPositionDlg.cxx b/sd/source/ui/dlg/BulletAndPositionDlg.cxx
index 5b2994e06f91..659833829517 100644
--- a/sd/source/ui/dlg/BulletAndPositionDlg.cxx
+++ b/sd/source/ui/dlg/BulletAndPositionDlg.cxx
@@ -26,6 +26,7 @@
 #include <i18nlangtag/mslangid.hxx>
 #include <editeng/numitem.hxx>
 #include <svl/eitem.hxx>
+#include <svl/itempool.hxx>
 #include <vcl/svapp.hxx>
 #include <svx/colorbox.hxx>
 #include <svx/strarray.hxx>
diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.hxx b/sd/source/ui/dlg/PhotoAlbumDialog.hxx
index 75c20fd5ccc6..fced2d7c32c6 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.hxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.hxx
@@ -16,6 +16,8 @@
 #include <svx/graphctl.hxx>
 #include <xmloff/autolayout.hxx>
 
+#include <com/sun/star/awt/Size.hpp>
+
 namespace com { namespace sun { namespace star { namespace drawing { class XDrawPage; } } } }
 namespace com { namespace sun { namespace star { namespace drawing { class XDrawPages; } } } }
 namespace com { namespace sun { namespace star { namespace graphic { class XGraphicProvider; } } } }
diff --git a/sd/source/ui/inc/AccessibleOutlineEditSource.hxx b/sd/source/ui/inc/AccessibleOutlineEditSource.hxx
index f177d05143f3..08ae8efab64a 100644
--- a/sd/source/ui/inc/AccessibleOutlineEditSource.hxx
+++ b/sd/source/ui/inc/AccessibleOutlineEditSource.hxx
@@ -22,6 +22,7 @@
 
 #include <svl/SfxBroadcaster.hxx>
 #include <svl/lstner.hxx>
+#include <tools/link.hxx>
 #include <editeng/unoedsrc.hxx>
 #include <editeng/unoforou.hxx>
 #include <editeng/unoviwou.hxx>
diff --git a/sd/source/ui/inc/BulletAndPositionDlg.hxx b/sd/source/ui/inc/BulletAndPositionDlg.hxx
index fe16cdd539ab..63139c3fc0dc 100644
--- a/sd/source/ui/inc/BulletAndPositionDlg.hxx
+++ b/sd/source/ui/inc/BulletAndPositionDlg.hxx
@@ -23,11 +23,8 @@
 #include <vector>
 #include <memory>
 
-#include <sfx2/tabdlg.hxx>
-#include <svx/Palette.hxx>
 #include <editeng/numdef.hxx>
 #include <editeng/svxenum.hxx>
-#include <svtools/ctrlbox.hxx>
 #include <vcl/weld.hxx>
 #include "View.hxx"
 #include <cui/numberingpreview.hxx>
diff --git a/sd/source/ui/inc/assclass.hxx b/sd/source/ui/inc/assclass.hxx
index d5d44f29ee84..87cbb4e77c16 100644
--- a/sd/source/ui/inc/assclass.hxx
+++ b/sd/source/ui/inc/assclass.hxx
@@ -23,6 +23,7 @@
 #include <memory>
 
 #include <sddllapi.h>
+#include <vcl/window.hxx>
 
 #define MAX_PAGES 10
 
diff --git a/sd/source/ui/inc/createcustomanimationpanel.hxx b/sd/source/ui/inc/createcustomanimationpanel.hxx
index e397ec6b8d32..7005d71abd44 100644
--- a/sd/source/ui/inc/createcustomanimationpanel.hxx
+++ b/sd/source/ui/inc/createcustomanimationpanel.hxx
@@ -21,6 +21,11 @@
 #define INCLUDED_SD_SOURCE_UI_INC_CREATECUSTOMANIMATIONPANEL_HXX
 
 #include <sal/config.h>
+#include <vcl/window.hxx>
+
+#include <com/sun/star/frame/XFrame.hpp>
+
+#include "ViewShell.hxx"
 
 namespace sd {
 
diff --git a/sd/source/ui/inc/createslidetransitionpanel.hxx b/sd/source/ui/inc/createslidetransitionpanel.hxx
index f6431aeecefd..564e9a689190 100644
--- a/sd/source/ui/inc/createslidetransitionpanel.hxx
+++ b/sd/source/ui/inc/createslidetransitionpanel.hxx
@@ -21,6 +21,11 @@
 #define INCLUDED_SD_SOURCE_UI_INC_CREATESLIDETRANSITIONPANEL_HXX
 
 #include <sal/config.h>
+#include <vcl/window.hxx>
+
+#include <com/sun/star/frame/XFrame.hpp>
+
+#include "ViewShell.hxx"
 
 namespace sd {
 
diff --git a/sd/source/ui/inc/dlgpage.hxx b/sd/source/ui/inc/dlgpage.hxx
index b0ffd2aa7454..5bf0c0ff6fda 100644
--- a/sd/source/ui/inc/dlgpage.hxx
+++ b/sd/source/ui/inc/dlgpage.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SD_SOURCE_UI_INC_DLGPAGE_HXX
 
 #include <sfx2/tabdlg.hxx>
+#include <svx/xtable.hxx>
 
 class SfxObjectShell;
 enum class ChangeType;
diff --git a/sd/source/ui/inc/docprev.hxx b/sd/source/ui/inc/docprev.hxx
index e2700ede7574..5a37851bcf15 100644
--- a/sd/source/ui/inc/docprev.hxx
+++ b/sd/source/ui/inc/docprev.hxx
@@ -22,6 +22,8 @@
 
 #include <tools/gen.hxx>
 #include <tools/wintypes.hxx>
+#include <vcl/ctrl.hxx>
+#include <vcl/window.hxx>
 
 #include <rtl/ref.hxx>
 
diff --git a/sd/source/ui/inc/filedlg.hxx b/sd/source/ui/inc/filedlg.hxx
index 36da05e13933..84f284a2e7e8 100644
--- a/sd/source/ui/inc/filedlg.hxx
+++ b/sd/source/ui/inc/filedlg.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SD_SOURCE_UI_INC_FILEDLG_HXX
 
 #include <vcl/errcode.hxx>
+#include <vcl/weld.hxx>
 
 #include <memory>
 
diff --git a/sd/source/ui/inc/registerinterfaces.hxx b/sd/source/ui/inc/registerinterfaces.hxx
index 8d30575e9455..cdf037e60df1 100644
--- a/sd/source/ui/inc/registerinterfaces.hxx
+++ b/sd/source/ui/inc/registerinterfaces.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SD_SOURCE_UI_INC_REGISTERINTERFACES_HXX
 
 #include <sal/config.h>
+#include <sfx2/module.hxx>
 
 namespace sd { namespace ui { namespace table {
 
diff --git a/sd/source/ui/inc/sdpopup.hxx b/sd/source/ui/inc/sdpopup.hxx
index 559cb5a9b080..ae16440ef8c1 100644
--- a/sd/source/ui/inc/sdpopup.hxx
+++ b/sd/source/ui/inc/sdpopup.hxx
@@ -20,6 +20,7 @@
 #ifndef INCLUDED_SD_SOURCE_UI_INC_SDPOPUP_HXX
 #define INCLUDED_SD_SOURCE_UI_INC_SDPOPUP_HXX
 
+#include <i18nlangtag/lang.h>
 #include <vcl/menu.hxx>
 
 class SvxFieldData;
diff --git a/sd/source/ui/inc/tablefunction.hxx b/sd/source/ui/inc/tablefunction.hxx
index b6e14c63e412..6593cce9c494 100644
--- a/sd/source/ui/inc/tablefunction.hxx
+++ b/sd/source/ui/inc/tablefunction.hxx
@@ -22,6 +22,9 @@
 
 #include <sal/config.h>
 
+#include <tools/stream.hxx>
+#include <drawdoc.hxx>
+
 namespace sd {
 
 void CreateTableFromRTF( SvStream& rStream, SdDrawDocument* pModel );
diff --git a/sd/source/ui/inc/tpaction.hxx b/sd/source/ui/inc/tpaction.hxx
index b6a323efdc8e..bd862e2135c4 100644
--- a/sd/source/ui/inc/tpaction.hxx
+++ b/sd/source/ui/inc/tpaction.hxx
@@ -23,6 +23,7 @@
 #include <com/sun/star/presentation/ClickAction.hpp>
 #include <sfx2/tabdlg.hxx>
 #include <sfx2/basedlgs.hxx>
+#include <svx/xtable.hxx>
 #include "sdtreelb.hxx"
 
 #include <vector>
diff --git a/sd/source/ui/inc/unchss.hxx b/sd/source/ui/inc/unchss.hxx
index b8ecc2be23d3..dfdf040413e3 100644
--- a/sd/source/ui/inc/unchss.hxx
+++ b/sd/source/ui/inc/unchss.hxx
@@ -22,6 +22,8 @@
 
 #include <memory>
 
+#include <svl/itemset.hxx>
+
 #include <sdundo.hxx>
 
 class SfxItemSet;
diff --git a/sd/source/ui/inc/undoback.hxx b/sd/source/ui/inc/undoback.hxx
index 61024b036c5d..ed1d6e1d56b1 100644
--- a/sd/source/ui/inc/undoback.hxx
+++ b/sd/source/ui/inc/undoback.hxx
@@ -24,6 +24,8 @@
 
 #include <sdundo.hxx>
 
+#include <svl/itemset.hxx>
+
 class SdDrawDocument;
 class SdPage;
 class SfxItemSet;
diff --git a/sd/source/ui/inc/unokywds.hxx b/sd/source/ui/inc/unokywds.hxx
index d6855d2cf1c8..c28d26e05e4b 100644
--- a/sd/source/ui/inc/unokywds.hxx
+++ b/sd/source/ui/inc/unokywds.hxx
@@ -22,8 +22,6 @@
 
 #include <sal/config.h>
 
-#include <sal/types.h>
-
 // SdUnoPseudoStyleFamily
 inline const char sUNO_PseudoSheet_Title[] = "title";
 inline const char sUNO_PseudoSheet_SubTitle[] = "subtitle";
diff --git a/sd/source/ui/remotecontrol/ZeroconfService.hxx b/sd/source/ui/remotecontrol/ZeroconfService.hxx
index 8516cf7404fe..e6c02e26868a 100644
--- a/sd/source/ui/remotecontrol/ZeroconfService.hxx
+++ b/sd/source/ui/remotecontrol/ZeroconfService.hxx
@@ -10,8 +10,6 @@
 #define ZEROCONF_SERVICE
 
 #include <string>
-#include <stdio.h>
-#include <stdlib.h>
 
 /**
 * The port used by LO's custom remote server discovery protocol.
diff --git a/sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx b/sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
index 648466047a7e..37761b4b9904 100644
--- a/sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
+++ b/sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
@@ -20,6 +20,8 @@
 #ifndef INCLUDED_SD_SOURCE_UI_SIDEBAR_CURRENTMASTERPAGESSELECTOR_HXX
 #define INCLUDED_SD_SOURCE_UI_SIDEBAR_CURRENTMASTERPAGESSELECTOR_HXX
 
+#include <svl/lstner.hxx>
+
 #include "MasterPagesSelector.hxx"
 
 
diff --git a/sd/source/ui/sidebar/MasterPagesSelector.hxx b/sd/source/ui/sidebar/MasterPagesSelector.hxx
index fa22290a15d6..76cb262e4f8a 100644
--- a/sd/source/ui/sidebar/MasterPagesSelector.hxx
+++ b/sd/source/ui/sidebar/MasterPagesSelector.hxx
@@ -20,9 +20,9 @@
 #ifndef INCLUDED_SD_SOURCE_UI_SIDEBAR_MASTERPAGESSELECTOR_HXX
 #define INCLUDED_SD_SOURCE_UI_SIDEBAR_MASTERPAGESSELECTOR_HXX
 
+#include <map>
 #include <memory>
 #include "MasterPageContainer.hxx"
-#include <SlideSorterViewShell.hxx>
 #include "PreviewValueSet.hxx"
 #include <sfx2/sidebar/ILayoutableWindow.hxx>
 
diff --git a/sd/source/ui/slideshow/slideshowviewimpl.hxx b/sd/source/ui/slideshow/slideshowviewimpl.hxx
index 984f7e1a010a..7c559fa4f403 100644
--- a/sd/source/ui/slideshow/slideshowviewimpl.hxx
+++ b/sd/source/ui/slideshow/slideshowviewimpl.hxx
@@ -29,7 +29,6 @@
 #include <com/sun/star/awt/XPaintListener.hpp>
 #include <com/sun/star/presentation/XSlideShowView.hpp>
 #include <cppcanvas/spritecanvas.hxx>
-#include <tools/gen.hxx>
 
 #include <slideshow.hxx>
 
diff --git a/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx b/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
index a73c966aef38..16528627179d 100644
--- a/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
+++ b/sd/source/ui/slidesorter/inc/view/SlsToolTip.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SD_SOURCE_UI_SLIDESORTER_INC_VIEW_SLSTOOLTIP_HXX
 
 #include <model/SlsSharedPageDescriptor.hxx>
+#include <rtl/ustring.hxx>
 #include <vcl/timer.hxx>
 
 namespace sd { namespace slidesorter { class SlideSorter; } }
diff --git a/sd/source/ui/unoidl/unopool.hxx b/sd/source/ui/unoidl/unopool.hxx
index db7e009d4baa..fb71522dec3e 100644
--- a/sd/source/ui/unoidl/unopool.hxx
+++ b/sd/source/ui/unoidl/unopool.hxx
@@ -22,6 +22,9 @@
 
 #include <sal/config.h>
 
+#include <com/sun/star/uno/Reference.hxx>
+#include <drawdoc.hxx>
+
 css::uno::Reference<css::uno::XInterface> SdUnoCreatePool(
     SdDrawDocument * pDrawModel);

More information about the Libreoffice-commits mailing list