[Libreoffice-commits] core.git: xmloff/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Tue Jul 16 07:30:29 UTC 2019


 xmloff/source/style/HatchStyle.cxx |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

New commits:
commit d49c33bb3dfeed8e1ed9b07cc5b1a4587f918c75
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Mon Jul 15 20:32:33 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Jul 16 09:29:43 2019 +0200

    cid#1448448 Unchecked return value
    
    Change-Id: I195cc073ff7557d30fbffcb97778751908634303
    Reviewed-on: https://gerrit.libreoffice.org/75660
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/xmloff/source/style/HatchStyle.cxx b/xmloff/source/style/HatchStyle.cxx
index c23ff4b719c8..899223754c61 100644
--- a/xmloff/source/style/HatchStyle.cxx
+++ b/xmloff/source/style/HatchStyle.cxx
@@ -125,13 +125,12 @@ void XMLHatchStyleImport::importXML(
                 rUnitConverter.convertMeasureToCore(aHatch.Distance, rStrValue);
                 break;
             case XML_TOK_HATCH_ROTATION:
-                {
-                    sal_Int32 nValue;
-                    ::sax::Converter::convertNumber(nValue, rStrValue, 0, 3600);
-                    aHatch.Angle = sal_Int16( nValue );
-                }
+            {
+                sal_Int32 nValue;
+                if (::sax::Converter::convertNumber(nValue, rStrValue, 0, 3600))
+                    aHatch.Angle = sal_Int16(nValue);
                 break;
-
+            }
             default:
                 SAL_INFO("xmloff.style", "Unknown token at import hatch style");
         }


More information about the Libreoffice-commits mailing list