[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - dbaccess/source

Xisco Fauli (via logerrit) logerrit at kemper.freedesktop.org
Wed Jul 17 21:12:46 UTC 2019


 dbaccess/source/filter/hsqldb/rowinputbinary.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 08bc5b49cb4fed31c3c08c61f178ee021db87246
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Wed Jul 10 19:06:13 2019 +0200
Commit:     Thorsten Behrens <Thorsten.Behrens at CIB.de>
CommitDate: Wed Jul 17 23:11:58 2019 +0200

    tdf#126268: Check for the sign value at the right place
    
    This commit contains 25277bcb727994072239c9c2549c271fdd62150e
    and 2e26ef34bf1a2e5d1293e45cf3b1415d9514b056 for backporting
    
    Code introduced in 6039d2463b4cc503b963811b3b1471de3291ee09
    
    Unittest removed in libreoffice-6-2 branch
    See 7991a4d718c282f1fd999e76f683e333b5c220af
    
    Change-Id: Id0e249e47a91b274a247fb7e8b71353114149650
    Reviewed-on: https://gerrit.libreoffice.org/75375
    Tested-by: Jenkins
    Reviewed-by: Lionel Elie Mamane <lionel at mamane.lu>
    Reviewed-by: Xisco FaulĂ­ <xiscofauli at libreoffice.org>
    Reviewed-on: https://gerrit.libreoffice.org/75420
    Reviewed-by: Michael Stahl <Michael.Stahl at cib.de>
    Signed-off-by: Xisco Fauli <xiscofauli at libreoffice.org>
    Reviewed-on: https://gerrit.libreoffice.org/75761
    Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>

diff --git a/dbaccess/source/filter/hsqldb/rowinputbinary.cxx b/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
index 5a447cacb4f3..cb02cde52a23 100644
--- a/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
+++ b/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
@@ -89,10 +89,10 @@ OUString lcl_double_dabble(const std::vector<sal_uInt8>& bytes)
 OUString lcl_makeStringFromBigint(const std::vector<sal_uInt8>& bytes)
 {
     std::vector<sal_uInt8> aBytes{ bytes };
-
     OUStringBuffer sRet;
+
     // two's complement
-    if (aBytes[0] == 1)
+    if ((aBytes[0] & 0x80) != 0)
     {
         sRet.append("-");
         for (auto& byte : aBytes)


More information about the Libreoffice-commits mailing list