[Libreoffice-commits] core.git: 4 commits - sd/source solenv/gbuildtojson toolkit/source vcl/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/view/sdwindow.cxx       |    2 +-
 solenv/gbuildtojson/gbuildtojson.cxx |    2 +-
 toolkit/source/awt/vclxtoolkit.cxx   |    1 +
 vcl/source/window/printdlg.cxx       |    2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 9b25e24571cd6ee644416158b493188354d961f7
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Jul 17 20:10:58 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Jul 18 09:37:12 2019 +0200

    cid#1448417 silence Unchecked return value from library
    
    Change-Id: I61b3a4408942b98e1ef0562b236b96335a8c5867
    Reviewed-on: https://gerrit.libreoffice.org/75805
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/solenv/gbuildtojson/gbuildtojson.cxx b/solenv/gbuildtojson/gbuildtojson.cxx
index 7c2429e60d20..00bc6ee8abb8 100644
--- a/solenv/gbuildtojson/gbuildtojson.cxx
+++ b/solenv/gbuildtojson/gbuildtojson.cxx
@@ -55,7 +55,7 @@ int main(int argc, char** argv)
         stringstream contents;
         contents << filestream.rdbuf();
         filestream.close();
-        remove(varandfile.second.c_str());
+        (void)remove(varandfile.second.c_str());
         string escapedcontents;
         for(auto& c : contents.str())
         {
commit 0b96e4cceb5e078029a72271c30088b688f4bb7a
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Jul 17 20:04:00 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Jul 18 09:36:57 2019 +0200

    cid#1448511 silence Out-of-bounds access
    
    Change-Id: I11920faa3327bfc74e9bfe8a94864a9caaa9b147
    Reviewed-on: https://gerrit.libreoffice.org/75803
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/toolkit/source/awt/vclxtoolkit.cxx b/toolkit/source/awt/vclxtoolkit.cxx
index 42c135c7b889..96699c246d19 100644
--- a/toolkit/source/awt/vclxtoolkit.cxx
+++ b/toolkit/source/awt/vclxtoolkit.cxx
@@ -1398,6 +1398,7 @@ vcl::Window* VCLXToolkit::ImplCreateWindow( VCLXWindow** ppNewComp,
 
                                 rtl_getGlobalProcessId( reinterpret_cast<sal_uInt8*>(processID) );
 
+                                // coverity[overrun-buffer-arg : FALSE] - coverity has difficulty with css::uno::Sequence
                                 css::uno::Sequence<sal_Int8> processIdSeq(processID, 16);
 
                                 css::uno::Any anyHandle = xSystemDepParent->getWindowHandle(processIdSeq, SYSTEM_DEPENDENT_TYPE);
commit cd7fe8938160015ed8bf53b8164d26fca99e7074
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Jul 17 20:08:16 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Jul 18 09:36:45 2019 +0200

    cid#1448365 silence Arguments in wrong order
    
    Change-Id: I20a64d73add3636e02e02ea970577c0505e2b5fd
    Reviewed-on: https://gerrit.libreoffice.org/75804
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index 758a1c444b7c..df1a8c7bac8c 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -1022,7 +1022,7 @@ void PrintDialog::checkPaperSize( Size& rPaperSize )
     if ( (eOrientation == Orientation::Portrait && rPaperSize.Width() > rPaperSize.Height()) ||
          (eOrientation == Orientation::Landscape && rPaperSize.Width() < rPaperSize.Height()) )
     {
-        // coverity[swapped_arguments : FALSE] - this is in the correct order
+        // coverity[swapped-arguments : FALSE] - this is in the correct order
         rPaperSize = Size( rPaperSize.Height(), rPaperSize.Width() );
     }
 }
commit 5e9e09e7bff0cb99b48dcf3af942a45b573ac7b5
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Jul 17 19:57:55 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Jul 18 09:36:31 2019 +0200

    cid#1451632 Dereference after null check
    
    Change-Id: I5ee95a9341896b8462235ece933fa70773247c92
    Reviewed-on: https://gerrit.libreoffice.org/75802
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sd/source/ui/view/sdwindow.cxx b/sd/source/ui/view/sdwindow.cxx
index 7a30096c52fd..fa355dfea869 100644
--- a/sd/source/ui/view/sdwindow.cxx
+++ b/sd/source/ui/view/sdwindow.cxx
@@ -268,7 +268,7 @@ void Window::Command(const CommandEvent& rCEvt)
     //show the text edit outliner view cursor
     else if (!HasFocus() && rCEvt.GetCommand() == CommandEventId::CursorPos)
     {
-        OutlinerView* pOLV = mpViewShell->GetView()->GetTextEditOutlinerView();
+        OutlinerView* pOLV = mpViewShell ? mpViewShell->GetView()->GetTextEditOutlinerView() : nullptr;
         if (pOLV && this == pOLV->GetWindow())
         {
             GrabFocus();