[Libreoffice-commits] core.git: svx/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Jul 19 07:40:02 UTC 2019


 svx/source/svdraw/svditer.cxx |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 04d661cfa2794cd4d7e1833dd795b3755c8b2d60
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Jul 18 12:22:26 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Jul 19 09:39:18 2019 +0200

    cid#1448251 Unchecked dynamic_cast
    
    Change-Id: I96b87d05d6633849d7a32a40e87b9fb4ee48b15d
    Reviewed-on: https://gerrit.libreoffice.org/75916
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/svx/source/svdraw/svditer.cxx b/svx/source/svdraw/svditer.cxx
index 45134a7fb86e..874f1caac9d4 100644
--- a/svx/source/svdraw/svditer.cxx
+++ b/svx/source/svdraw/svditer.cxx
@@ -74,11 +74,8 @@ SdrObjListIter::SdrObjListIter(const SdrPage* pSdrPage, SdrIterMode eMode, bool
     mbReverse(bReverse),
     mbUseZOrder(true)
 {
-    if(nullptr != pSdrPage)
-    {
-        ImpProcessObjectList(*dynamic_cast< const SdrObjList* >(pSdrPage), eMode);
-    }
-
+    if (const SdrObjList* pList = dynamic_cast<const SdrObjList*>(pSdrPage))
+        ImpProcessObjectList(*pList, eMode);
     Reset();
 }
 


More information about the Libreoffice-commits mailing list