[Libreoffice-commits] core.git: 2 commits - basic/source vcl/unx

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Jul 19 07:43:59 UTC 2019


 basic/source/runtime/methods.cxx            |    2 +-
 vcl/unx/generic/fontmanager/fontmanager.cxx |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit ff17310476041ab44cd312731f83fa7891bac599
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Jul 18 10:24:52 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Jul 19 09:43:27 2019 +0200

    cid#1448256 Unchecked return value
    
    Change-Id: I13c95bdbfc3161cca3b136266c5fd2e57b34a093
    Reviewed-on: https://gerrit.libreoffice.org/75870
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index de9b5f91badd..1119adf3d9e1 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -777,7 +777,7 @@ void SbRtl_FileLen(StarBASIC *, SbxArray & rPar, bool)
         else
         {
             DirectoryItem aItem;
-            DirectoryItem::get( getFullPath( aStr ), aItem );
+            (void)DirectoryItem::get( getFullPath( aStr ), aItem );
             FileStatus aFileStatus( osl_FileStatus_Mask_FileSize );
             aItem.getFileStatus( aFileStatus );
             nLen = static_cast<sal_Int32>(aFileStatus.getFileSize());
commit ba9c0b8565428f600b443fd4c2a5876892a91d77
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Jul 18 11:09:32 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Jul 19 09:43:14 2019 +0200

    cid#1448455 Unchecked return value
    
    Change-Id: I4526fbd939934fc4233279d9839f72c781a588b5
    Reviewed-on: https://gerrit.libreoffice.org/75894
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/generic/fontmanager/fontmanager.cxx b/vcl/unx/generic/fontmanager/fontmanager.cxx
index 8af7d1a53b67..8389ba279ba1 100644
--- a/vcl/unx/generic/fontmanager/fontmanager.cxx
+++ b/vcl/unx/generic/fontmanager/fontmanager.cxx
@@ -239,8 +239,8 @@ std::vector<std::unique_ptr<PrintFontManager::PrintFont>> PrintFontManager::anal
                     if (osl::DirectoryItem::get(aURL, aItem) == osl::File::E_None)
                     {
                         osl::FileStatus aFileStatus( osl_FileStatus_Mask_FileSize );
-                        aItem.getFileStatus( aFileStatus );
-                        fileSize = aFileStatus.getFileSize();
+                        if (aItem.getFileStatus(aFileStatus) == osl::File::E_None)
+                            fileSize = aFileStatus.getFileSize();
                     }
                 }
             }


More information about the Libreoffice-commits mailing list