[Libreoffice-commits] core.git: qadevOOo/tests

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Sat Jul 20 19:14:28 UTC 2019


 qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 74ce2c90ecc6f6375ff6743efdd0b84358ebd6a3
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sat Jul 20 15:57:59 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sat Jul 20 21:13:29 2019 +0200

    cid#1448454 RV: Bad use of return value
    
    Change-Id: I704b432a09bb4bbd0192bd0a3ae6b39012a14110
    Reviewed-on: https://gerrit.libreoffice.org/76024
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java b/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
index e262a15c8a33..dc775c6e1d8c 100644
--- a/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
+++ b/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
@@ -319,7 +319,7 @@ public class _XMultiSelectionSupplier extends MultiMethodTest {
             i++;
 
             if (ObjCompare != null) {
-                ObjCompare.compare(shouldElement, nextElement);
+                compRes = ObjCompare.compare(shouldElement, nextElement) == 0;
             } else {
                 compRes = util.ValueComparer.equalValue(shouldElement, nextElement);
             }


More information about the Libreoffice-commits mailing list