[Libreoffice-commits] core.git: sd/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed Jul 24 14:05:52 UTC 2019


 sd/source/ui/unoidl/UnoDocumentSettings.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 1733b527ac07fcb0067905e7277227f086b53afb
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Jul 24 08:43:28 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Jul 24 16:04:39 2019 +0200

    cid#1451642 silence Division or modulo by zero
    
    Change-Id: I728528ecbb69c23b63807944e4ae0beb9cb86cbb
    Reviewed-on: https://gerrit.libreoffice.org/76222
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sd/source/ui/unoidl/UnoDocumentSettings.cxx b/sd/source/ui/unoidl/UnoDocumentSettings.cxx
index 3add9902b8c7..2b426a632380 100644
--- a/sd/source/ui/unoidl/UnoDocumentSettings.cxx
+++ b/sd/source/ui/unoidl/UnoDocumentSettings.cxx
@@ -701,7 +701,9 @@ DocumentSettings::_setPropertyValues(const PropertyMapEntry** ppEntries,
                     sal_Int32 nValue = 0;
                     if( *pValues >>= nValue )
                     {
-                        Fraction aFract( pDoc->GetUIScale().GetNumerator(), nValue );
+                        auto nNumerator = pDoc->GetUIScale().GetNumerator();
+                        assert(nNumerator != 0);
+                        Fraction aFract(nNumerator, nValue);
                         pDoc->SetUIScale( aFract );
                         bOk = true;
                         bChanged = true;


More information about the Libreoffice-commits mailing list