[Libreoffice-commits] core.git: sc/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed Jul 24 15:17:23 UTC 2019


 sc/source/core/data/validat.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 672da0902b406c88042dfa3b48dd565700514343
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Jul 24 11:28:35 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Jul 24 17:16:12 2019 +0200

    cid#1448321 Dereference after null check
    
    Change-Id: I724e4c19df9aa446f496b21ea5f3918e2def28da
    Reviewed-on: https://gerrit.libreoffice.org/76249
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/core/data/validat.cxx b/sc/source/core/data/validat.cxx
index 0444dbf2ef5b..4e0e62ddcada 100644
--- a/sc/source/core/data/validat.cxx
+++ b/sc/source/core/data/validat.cxx
@@ -846,7 +846,7 @@ bool ScValidationData::GetSelectionFromFormula(
 
             if( pEntry )
             {
-                assert(pEntry);
+                assert(pStrings);
                 pStrings->push_back(*pEntry);
                 n++;
             }


More information about the Libreoffice-commits mailing list