[Libreoffice-commits] core.git: 2 commits - reportbuilder/java sd/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed Jul 24 19:34:03 UTC 2019


 reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java |    1 -
 sd/source/ui/dlg/BulletAndPositionDlg.cxx                                                |    1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 852d5b7b3bc289c1018da5373dea50b7aa68ef0b
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Jul 24 11:45:00 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Jul 24 21:32:49 2019 +0200

    cid#1448272 RV: Bad use of return value
    
    Change-Id: I716c4e617ae2493385391f96567e2fb4571cd440
    Reviewed-on: https://gerrit.libreoffice.org/76253
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java b/reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java
index 0a3f23c6986e..330a5e091aa0 100644
--- a/reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java
+++ b/reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java
@@ -1026,7 +1026,6 @@ public abstract class OfficeDocumentReportTarget extends AbstractReportTarget
                 DocumentBuilder dBuilder = dbFactory.newDocumentBuilder();
                 Document document = dBuilder.parse(new InputSource(inputStream));
 
-                document.getElementsByTagName("document-meta/meta/generator");
                 Node node = document.getFirstChild().getFirstChild().getFirstChild().getFirstChild();
                 String creator = node.getNodeValue();
                 node.setNodeValue(creator + "/report_builder");
commit 554e7d8ee6bee44d87392476a498fb7f3f6068c6
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Jul 24 11:51:10 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Jul 24 21:32:22 2019 +0200

    cid#1448222 Out-of-bounds read
    
    possibly coverity gold
    
    Change-Id: I6443225482eab5be31e1e12d282e420e767f23b2
    Reviewed-on: https://gerrit.libreoffice.org/76254
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sd/source/ui/dlg/BulletAndPositionDlg.cxx b/sd/source/ui/dlg/BulletAndPositionDlg.cxx
index 26e81878661f..17e7b20136f2 100644
--- a/sd/source/ui/dlg/BulletAndPositionDlg.cxx
+++ b/sd/source/ui/dlg/BulletAndPositionDlg.cxx
@@ -521,6 +521,7 @@ void SvxBulletAndPositionDlg::InitControls()
     {
         nNumberingType = SVX_NUM_NUMBER_NONE;
         bAllLevel = false;
+        bSameDistBorderNum = false;
         bSameBulRelSize = false;
         bSameBulColor = false;
         bSameStart = false;


More information about the Libreoffice-commits mailing list