[Libreoffice-commits] core.git: vcl/qa

Julien Nabet (via logerrit) logerrit at kemper.freedesktop.org
Sun Jul 28 11:25:48 UTC 2019


 vcl/qa/cppunit/pdfexport/pdfexport.cxx |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 236593a0544ea41e37d35b8fac83b31d0e7c5b67
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Sun Jul 28 11:03:51 2019 +0200
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Sun Jul 28 13:25:12 2019 +0200

    tdf#126559: vcl_pdfexport unit test failure
    
    Revert back part of 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be
    Some investigation is needed here
    
    Change-Id: I4fc0648bdef0df6cd2cd4b114dd479bc0a722fe6
    Reviewed-on: https://gerrit.libreoffice.org/76500
    Reviewed-by: Jan-Marek Glogowski <glogow at fbihome.de>
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    Tested-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 6b958683d143..89f10ec3cf9e 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -364,7 +364,8 @@ void PdfExportTest::testTdf107868()
 {
     // No need to run it on Windows, since it would use GDI printing, and not trigger PDF export
     // which is the intent of the test.
-#if !defined _WIN32
+// FIXME: Why does this fail on macOS?
+#if !defined MACOSX && !defined _WIN32
 
     // Import the bugdoc and print to PDF.
     OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + "tdf107868.odt";
@@ -618,7 +619,8 @@ void PdfExportTest::testSofthyphenPos()
 {
     // No need to run it on Windows, since it would use GDI printing, and not trigger PDF export
     // which is the intent of the test.
-#if !defined _WIN32
+// FIXME: Why does this fail on macOS?
+#if !defined MACOSX && !defined _WIN32
 
     // Import the bugdoc and print to PDF.
     OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + "softhyphen_pdf.odt";


More information about the Libreoffice-commits mailing list