[Libreoffice-commits] core.git: sd/source

[Noel Grandin (via logerrit)]

 sd/source/filter/ppt/pptin.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e6adec29beadb83ebd3941275b99e2dd1be02f61
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Jun 6 13:31:52 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Thu Jun 6 21:17:00 2019 +0200

    tdf#125556 URL fragment leaked from one object..
    
    to another when importing Powerpoint ppt file
    
    regression from
        commit 4245454d0c3d6df2d0e0a75aed6f22f0a26ce3e2
        Date:   Wed Feb 28 15:50:29 2018 +0200
        loplugin:useuniqueptr in SdrPowerPointImport
    
    Change-Id: I5f415dfa1f6125629b9f3be1d799cb596c64c605
    Reviewed-on: https://gerrit.libreoffice.org/73602
    Reviewed-by: Xisco Faulí <xiscofauli at libreoffice.org>
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index 1e1ba2722922..793d26eabe88 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -378,9 +378,9 @@ bool ImplSdPPTImport::Import()
 
                                     nPropCount /= 6;    // 6 properties per hyperlink
 
-                                    SdHyperlinkEntry aHyperlink;
                                     for ( i = 0; i < nPropCount; i++ )
                                     {
+                                        SdHyperlinkEntry aHyperlink;
                                         aHyperlink.nIndex = 0;
                                         aPropItem.ReadUInt32( nType );
                                         if ( nType != VT_I4 )