[Libreoffice-commits] core.git: include/tools

[Stephan Bergmann (via logerrit)]

 include/tools/urlobj.hxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f270bd15fed87a9cb0f8dfa73b34c617d66f59c2
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Jun 21 10:01:06 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Fri Jun 21 12:19:27 2019 +0200

    Fix INetURLObject::setName description
    
    ...after 359e0b47a0f96ffa595a0c38a5e5318d797812fe "loplugin:unuseddefaultparams"
    had removed its nIndex and bIgnoreFinalSlash parameters denoting the segment
    whose name to set.
    
    (One would assume that a hierarchical URL always has a last segment, so the
    "[if] a last segment does not exist, false is returned" part be removed from the
    description.  But for a hierarchical URL with an empty (i.e., just "/" in the
    canonic form) path, setName("foo") actually returns false.)
    
    Change-Id: I35b96f4687784648c141e16c0806fe49d80c940a
    Reviewed-on: https://gerrit.libreoffice.org/74487
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/include/tools/urlobj.hxx b/include/tools/urlobj.hxx
index a1244bd7eba6..eb3b961c204b 100644
--- a/include/tools/urlobj.hxx
+++ b/include/tools/urlobj.hxx
@@ -569,7 +569,7 @@ public:
                       rtl_TextEncoding eCharset = RTL_TEXTENCODING_UTF8)
         const;
 
-    /** Set the name of a segment (preserving any parameters and any query or
+    /** Set the name of the last segment (preserving any parameters and any query or
         fragment part).
 
         @param rTheName  The new name.
@@ -580,7 +580,7 @@ public:
 
         @return  True if the name has successfully been modified (and the
         resulting URI is still valid).  If the path is not hierarchical, or
-        the specified segment does not exist, false is returned.  If false is
+        a last segment does not exist, false is returned.  If false is
         returned, the object is not modified.
      */
     bool setName(OUString const& rTheName,