[Libreoffice-commits] core.git: include/comphelper

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sat Mar 2 14:46:49 UTC 2019


 include/comphelper/sequence.hxx |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit e9c9848d30c90bd430193dd1b408db6889400063
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sat Mar 2 14:31:04 2019 +0100
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Sat Mar 2 15:46:27 2019 +0100

    Use implCopySequence to avoid overhead of non-const operator[]
    
    Change-Id: I1e2385c6c7270f7bac9748a61fbf56e3e4246e1c
    Reviewed-on: https://gerrit.libreoffice.org/68621
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/include/comphelper/sequence.hxx b/include/comphelper/sequence.hxx
index 59cd74fb1b83..7f134294ea57 100644
--- a/include/comphelper/sequence.hxx
+++ b/include/comphelper/sequence.hxx
@@ -91,10 +91,8 @@ namespace comphelper
 
         OSL_ENSURE(0 <= _nPos && _nPos < nLength, "invalid index");
 
-        for (sal_Int32 i = _nPos + 1; i < nLength; ++i)
-        {
-            _rSeq[i-1] = _rSeq[i];
-        }
+        T* pPos = _rSeq.getArray() + _nPos;
+        internal::implCopySequence(pPos + 1, pPos, nLength - _nPos - 1);
 
         _rSeq.realloc(nLength-1);
     }


More information about the Libreoffice-commits mailing list