[Libreoffice-commits] core.git: filter/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sun Mar 3 22:20:58 UTC 2019


 filter/source/msfilter/svdfppt.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 923c82a966d65e7b5a4b35573090567e93703eb5
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Sun Mar 3 19:00:34 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Sun Mar 3 23:20:35 2019 +0100

    Avoid unnecessary conversion to sal_uInt16
    
    (the negated value is ultimately passed to a short parameter of
    SvxLRSpaceItem::SetTextFirstLineOfstValue.  This change has no acutal effect on
    the result, but silences Clang -fsanitize=implicit-signed-integer-truncation
    warnings.
    
    Change-Id: Ieefab13b9594fb6e19953c5f0ca22b36141ff986
    Reviewed-on: https://gerrit.libreoffice.org/68648
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index 3cd0247d8fc5..ff31e39c2c48 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -6223,7 +6223,7 @@ void PPTParagraphObj::ApplyTo( SfxItemSet& rSet,  boost::optional< sal_Int16 >&
     {
         SvxLRSpaceItem aLRSpaceItem( EE_PARA_LRSPACE );
         sal_uInt16 nAbsLSpace = static_cast<sal_uInt16>( ( _nTextOfs * 2540 ) / 576 );
-        sal_uInt16 nFirstLineOffset = nAbsLSpace - static_cast<sal_uInt16>( ( _nBulletOfs * 2540 ) / 576 );
+        auto const nFirstLineOffset = nAbsLSpace - static_cast<sal_uInt16>( ( _nBulletOfs * 2540 ) / 576 );
         aLRSpaceItem.SetLeft( nAbsLSpace );
         aLRSpaceItem.SetTextFirstLineOfstValue( -nFirstLineOffset );
         rSet.Put( aLRSpaceItem );


More information about the Libreoffice-commits mailing list