[Libreoffice-commits] core.git: sw/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Mar 5 08:55:13 UTC 2019


 sw/source/filter/ww8/ww8scan.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 47078995c2aac781c7af5c5a36898a55fbe5cc13
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Mon Mar 4 20:49:44 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue Mar 5 09:54:45 2019 +0100

    Better types for nFc and nLen
    
    ...given that they get assigned with values of those types.  This change has no
    actual effect on the results, but silences Clang
    -fsanitize=implicit-signed-integer-truncation warnings like "implicit conversion
    from type 'long' of value -671088640 (64-bit, signed) to type 'sal_uInt32' (aka
    'unsigned int') changed the value to 3623878656 (32-bit, unsigned)".
    
    Change-Id: I763a9d85b9e40797312688551206c308fc3d36e3
    Reviewed-on: https://gerrit.libreoffice.org/68705
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 4d5ccaf9a1ea..1b747d1c5b95 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -3953,7 +3953,8 @@ void WW8PLCFx_SubDoc::advance()
 WW8PLCFx_FLD::WW8PLCFx_FLD( SvStream* pSt, const WW8Fib& rMyFib, short nType)
     : WW8PLCFx(rMyFib, true), rFib(rMyFib)
 {
-    long nFc, nLen;
+    WW8_FC nFc;
+    sal_Int32 nLen;
 
     switch( nType )
     {


More information about the Libreoffice-commits mailing list