[Libreoffice-commits] core.git: cui/qa dbaccess/qa

[Libreoffice Gerrit user]

 cui/qa/unit/data/cui-dialogs-test.txt           |    8 +++++++-
 dbaccess/qa/unit/data/dbaccess-dialogs-test.txt |   18 ++++++++++++++++--
 2 files changed, 23 insertions(+), 3 deletions(-)

New commits:
commit 94de7c0be2739de7fdaf11e9e55a1cc7083992f0
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Mar 6 16:41:25 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Mar 6 18:37:27 2019 +0100

    Blacklist some dialogs which won't get properly initialized
    
    ...so that at least Clang -fsanitize=implicit-signed-integer-truncation would
    generate warnings for them
    
    Change-Id: I76fd0aaa8e61784053e2b367b302fdd68c3859b4
    Reviewed-on: https://gerrit.libreoffice.org/68815
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/cui/qa/unit/data/cui-dialogs-test.txt b/cui/qa/unit/data/cui-dialogs-test.txt
index 64d4f2913bd3..8bab3ce88f5f 100644
--- a/cui/qa/unit/data/cui-dialogs-test.txt
+++ b/cui/qa/unit/data/cui-dialogs-test.txt
@@ -35,6 +35,13 @@
 # test case since they need some document and model data to work
 #
 # cui/ui/bitmaptabpage.ui
+# cui/ui/connpooloptions.ui <- not calling DriverListControl::Init for
+#   ConnectionPoolOptionsPage::m_pDriverList leaves its BrowseBox::mvCols empty, causing "implicit
+#   conversion from type 'int' of value -1 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned
+#   short') changed the value to 65535 (16-bit, unsigned)" when calling
+#     GetColumnId( static_cast<sal_uInt16>(mvCols.size()) - 1 );
+#   in BrowseBox::AutoSizeLastColumn (svtools/source/brwbox/brwbox1.cxx) with Clang
+#   -fsanitize=implicit-signed-integer-truncation
 # cui/ui/thesaurus.ui <- problems under Linux
 
 # this is part 1. in order to help the build time when building all
@@ -76,7 +83,6 @@ cui/ui/colorpage.ui
 cui/ui/colorpickerdialog.ui
 cui/ui/comment.ui
 cui/ui/connectortabpage.ui
-cui/ui/connpooloptions.ui
 cui/ui/croppage.ui
 cui/ui/cuiimapdlg.ui
 cui/ui/customizedialog.ui
diff --git a/dbaccess/qa/unit/data/dbaccess-dialogs-test.txt b/dbaccess/qa/unit/data/dbaccess-dialogs-test.txt
index 1fd47cd605a4..bcf728a0f006 100644
--- a/dbaccess/qa/unit/data/dbaccess-dialogs-test.txt
+++ b/dbaccess/qa/unit/data/dbaccess-dialogs-test.txt
@@ -33,6 +33,22 @@
 # currently deactivated, leads to problems and the test to not work
 # This is typically a hint that these should be hard-coded in the
 # test case since they need some document and model data to work
+# dbaccess/ui/joindialog.ui <- not calling ORelationControl::lateInit for
+#   DlgQryJoin::m_pTableControl member OTableListBoxControl::m_pRC_Tables leaves its
+#   BrowseBox::mvCols empty, causing "implicit conversion from type 'int' of value -1 (32-bit,
+#   signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65535 (16-bit,
+#   unsigned)" when calling
+#     GetColumnId( static_cast<sal_uInt16>(mvCols.size()) - 1 );
+#   in BrowseBox::AutoSizeLastColumn (svtools/source/brwbox/brwbox1.cxx) with Clang
+#   -fsanitize=implicit-signed-integer-truncation
+# dbaccess/ui/relationdialog.ui <- not calling ORelationControl::lateInit for
+#   ORelationDialog::m_xTableControl member OTableListBoxControl::m_pRC_Tables leaves its
+#   BrowseBox::mvCols empty, causing "implicit conversion from type 'int' of value -1 (32-bit,
+#   signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65535 (16-bit,
+#   unsigned)" when calling
+#     GetColumnId( static_cast<sal_uInt16>(mvCols.size()) - 1 );
+#   in BrowseBox::AutoSizeLastColumn (svtools/source/brwbox/brwbox1.cxx) with Clang
+#   -fsanitize=implicit-signed-integer-truncation
 # dbaccess/ui/rtfcopytabledialog.ui -> hangs execution, seems to wait for interaction somehow (?)
 
 dbaccess/ui/advancedsettingsdialog.ui
@@ -88,11 +104,9 @@ dbaccess/ui/parametersdialog.ui
 dbaccess/ui/queryfilterdialog.ui
 dbaccess/ui/sortdialog.ui
 dbaccess/ui/querypropertiesdialog.ui
-dbaccess/ui/relationdialog.ui
 dbaccess/ui/sqlexception.ui
 dbaccess/ui/textconnectionsettings.ui
 dbaccess/ui/password.ui
-dbaccess/ui/joindialog.ui
 dbaccess/ui/tablesfilterdialog.ui
 dbaccess/ui/tablesjoindialog.ui
 dbaccess/ui/savemodifieddialog.ui